Skip to content
  • enrica@apple.com's avatar
    Source/WebKit2: REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac). · b83b967f
    enrica@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=58055
    <rdar://problem/8862023>
            
    Reviewed by Oliver Hunt.
    
    Adding support for execCommand('undo') and execCommand('redo')
    in WebKit2 for Mac.
    
    * UIProcess/API/mac/PageClientImpl.h:
    * UIProcess/API/mac/PageClientImpl.mm:
    (WebKit::PageClientImpl::canUndoRedo): Added interaction with undomanager.
    (WebKit::PageClientImpl::executeUndoRedo): Added interaction with undomanager.
            
    Added new empty PageClient methods for other platforms.
    * UIProcess/API/qt/qwkpage.cpp:
    (QWKPagePrivate::canUndoRedo):
    (QWKPagePrivate::executeUndoRedo):
    * UIProcess/API/qt/qwkpage_p.h:
    * UIProcess/PageClient.h:
    * UIProcess/gtk/WebView.cpp:
    (WebKit::WebView::canUndoRedo):
    (WebKit::WebView::executeUndoRedo):
    * UIProcess/gtk/WebView.h:
    * UIProcess/win/WebView.cpp:
    (WebKit::WebView::canUndoRedo):
    (WebKit::WebView::executeUndoRedo):
    * UIProcess/win/WebView.h:
    
    * UIProcess/WebEditCommandProxy.cpp:
    (WebKit::WebEditCommandProxy::unapply): Added flag to allow dispatching
    of asychronous messages while waiting for a sync message reply.
    (WebKit::WebEditCommandProxy::reapply): Same as above.
    * UIProcess/WebPageProxy.cpp:
    (WebKit::WebPageProxy::canUndoRedo):
    (WebKit::WebPageProxy::executeUndoRedo):
    * UIProcess/WebPageProxy.h:
    * UIProcess/WebPageProxy.messages.in:
    * WebProcess/WebCoreSupport/WebEditorClient.cpp: Added missing implementation.
    (WebKit::WebEditorClient::canUndo):
    (WebKit::WebEditorClient::canRedo):
    (WebKit::WebEditorClient::undo):
    (WebKit::WebEditorClient::redo):
    
    LayoutTests: REGRESSION(WebKit2): execCommand('undo') doesn't work (Mac).
    https://bugs.webkit.org/show_bug.cgi?id=58055
    <rdar://problem/8862023>
    
    Reviewed by Oliver Hunt.
    
    * platform/mac-wk2/Skipped: Remove skipped tests related to undo/redo.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@83194 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    b83b967f