Skip to content
  • aroben@apple.com's avatar
    Don't notify the plugin when a targeted javascript: URL request completes · b7678630
    aroben@apple.com authored
    This matches Mozilla and WebKit1.
    
    Fixes <http://webkit.org/b/60568> <rdar://problem/8610657> REGRESSION (WebKit2): Flash
    plugin doesn't appear on a hanes.com page
    
    Test: plugins/get-targeted-javascript-url.html
    
    Reviewed by Anders Carlsson.
    
    Source/WebKit2:
    
    * WebProcess/Plugins/PluginView.cpp:
    (WebKit::PluginView::performJavaScriptURLRequest): Don't call back to the plugin if the
    request had a target.
    
    LayoutTests:
    
    Test what happens when a plugin makes a targeted javascript: request
    
    * plugins/get-targeted-javascript-url-expected.txt: Added.
    * plugins/get-targeted-javascript-url.html: Added.
    (startTest): Tell the plugin to make two targeted javascript: requests. One calls a function
    with a return value, the other calls a function with no return value.
    (finishTest): Check that both functions were called, and that we either didn't get an
    NPP_URLNotify call (like in Mozilla, WebKit1, and WebKit2), or got an NPP_URLNotify call
    with NPRES_DONE (like in Chrome).
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86259 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    b7678630