Skip to content
  • pdr@google.com's avatar
    Rename toScriptElement -> toScriptElementIfPossible · b38b6ff0
    pdr@google.com authored
    https://bugs.webkit.org/show_bug.cgi?id=113473
    
    Reviewed by Ryosuke Niwa.
    
    Rename ScriptElement::toScriptElement to ScriptElement::toScriptElementIfPossible to
    differentiate this function from other to*Element functions, and to better describe the
    function's behavior. Other to*Element functions do not return null if the cast fails,
    whereas toScriptElementIfPossible does.
    
    No new tests as this is just a refactoring.
    
    * dom/ScriptElement.cpp:
    (WebCore::toScriptElementIfPossible):
    * dom/ScriptElement.h:
    (WebCore):
    * dom/ScriptRunner.cpp:
    (WebCore::ScriptRunner::timerFired):
    
        This is the only unchecked return value but there isn't a security issue here.
    
    * html/HTMLOptionElement.cpp:
    (WebCore::HTMLOptionElement::collectOptionInnerText):
    * html/parser/HTMLConstructionSite.cpp:
    (WebCore::HTMLConstructionSite::attachLater):
    (WebCore::HTMLConstructionSite::insertForeignElement):
    * html/parser/HTMLScriptRunner.cpp:
    (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):
    (WebCore::HTMLScriptRunner::requestPendingScript):
    (WebCore::HTMLScriptRunner::runScript):
    * xml/parser/XMLDocumentParser.cpp:
    (WebCore::XMLDocumentParser::notifyFinished):
    * xml/parser/XMLDocumentParserLibxml2.cpp:
    (WebCore::XMLDocumentParser::startElementNs):
    (WebCore::XMLDocumentParser::endElementNs):
    * xml/parser/XMLDocumentParserQt.cpp:
    (WebCore::XMLDocumentParser::parseStartElement):
    (WebCore::XMLDocumentParser::parseEndElement):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@147057 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    b38b6ff0