Skip to content
  • zimmermann@webkit.org's avatar
    2009-08-11 Nikolas Zimmermann <nikolas.zimmermann@torchmobile.com> · b0121231
    zimmermann@webkit.org authored
            Reviewed by George Staikos.
    
            [WML] WMLPageState is not allowed to store the active card, it needs to be done per document
            https://bugs.webkit.org/show_bug.cgi?id=28180
    
            Don't store the active WMLCardElement in WMLPageState, but in WMLDocument.
            Otherwhise this may lead to crashes related to intrinsic event exeuction.
    
            Unfortunately select elements aren't testable by the layout tests, so adding
            a new manual test reproducing the crash.
    
            * manual-tests/wml/select-onpick-event-crash.wml: Added.
            * wml/WMLCardElement.cpp:
            (WebCore::WMLCardElement::determineActiveCard):
            * wml/WMLDoElement.cpp:
            (WebCore::WMLDoElement::defaultEventHandler):
            * wml/WMLDocument.cpp:
            (WebCore::WMLDocument::finishedParsing):
            * wml/WMLDocument.h:
            (WebCore::WMLDocument::activeCard):
            * wml/WMLGoElement.cpp:
            (WebCore::WMLGoElement::executeTask):
            * wml/WMLPageState.cpp:
            (WebCore::WMLPageState::WMLPageState):
            * wml/WMLPageState.h:
            * wml/WMLPrevElement.cpp:
            (WebCore::WMLPrevElement::executeTask):
            * wml/WMLRefreshElement.cpp:
            (WebCore::WMLRefreshElement::executeTask):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@47048 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    b0121231