Skip to content
  • hmuller@adobe.com's avatar
    [CSS Shapes] Empty polygons with non-zero shape-padding cause an ASSERT crash · ae389127
    hmuller@adobe.com authored
    https://bugs.webkit.org/show_bug.cgi?id=124324
    
    Reviewed by Andreas Kling.
    
    Source/WebCore:
    
    PolygonShape::shapePaddingBounds() and PolygonShape::shapeMarginBounds() no
    longer attempt to compute a new FloatPolygon when the original is empty, i.e.
    when it has less than three vertices.
    
    Tests: fast/shapes/shape-inside/shape-inside-empty-polygon-crash.html
           fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash.html
    
    * rendering/shapes/PolygonShape.cpp:
    (WebCore::PolygonShape::shapePaddingBounds): Don't compute a padding FloatPolygon if the original polygon is empty.
    (WebCore::PolygonShape::shapeMarginBounds): Don't compute a margin FloatPolygon if the original polygon is empty.
    
    LayoutTests:
    
    * fast/shapes/shape-inside/shape-inside-empty-polygon-crash-expected.txt: Added.
    * fast/shapes/shape-inside/shape-inside-empty-polygon-crash.html: Added.
    * fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash-expected.txt: Added.
    * fast/shapes/shape-outside-floats/shape-outside-floats-empty-polygon-crash.html: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159291 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    ae389127