Skip to content
  • apavlov@chromium.org's avatar
    Web Inspector: [Device Metrics] Remove the gutter overlay moving its... · aa967739
    apavlov@chromium.org authored
    Web Inspector: [Device Metrics] Remove the gutter overlay moving its functionality into the InspectorOverlay
    https://bugs.webkit.org/show_bug.cgi?id=97799
    
    Reviewed by Pavel Feldman.
    
    Source/WebCore:
    
    Re-applying r129746 with test flakiness fixed.
    
    In order to reduce the amount of port-specific code, the gutter overlay painted in the device metrics emulation mode
    has been replaced by the respective functionality in the HTML-based InspectorOverlay in WebCore. The InspectorOverlay
    now covers the entire WebView rather than the FrameView only.
    
    * inspector/InspectorController.cpp:
    (WebCore::InspectorController::webViewResized):
    (WebCore):
    * inspector/InspectorController.h:
    (WebCore):
    (InspectorController):
    * inspector/InspectorOverlay.cpp:
    (WebCore::InspectorOverlay::InspectorOverlay):
    (WebCore::InspectorOverlay::paint):
    (WebCore::InspectorOverlay::resize):
    (WebCore):
    (WebCore::InspectorOverlay::update):
    (WebCore::InspectorOverlay::drawGutter):
    (WebCore::InspectorOverlay::reset):
    * inspector/InspectorOverlay.h:
    (InspectorOverlay):
    * inspector/InspectorOverlayPage.html: Introduce the gutter painting functionality previously found in the Chromium's
    DeviceMetricsSupport class, which used to implement WebPageOverlay.
    
    Source/WebKit/chromium:
    
    - Dispatch the webViewResized() event on InspectorController, which is necessary to update the InspectorOverlay.
    - Remove the gutter overlay painting code.
    
    * src/WebDevToolsAgentImpl.cpp:
    (WebKit::DeviceMetricsSupport::DeviceMetricsSupport):
    (WebKit::DeviceMetricsSupport::~DeviceMetricsSupport):
    (WebKit::WebDevToolsAgentImpl::attach):
    (WebKit::WebDevToolsAgentImpl::webViewResized):
    (WebKit::WebDevToolsAgentImpl::overrideDeviceMetrics):
    * src/WebDevToolsAgentImpl.h:
    (WebDevToolsAgentImpl):
    * src/WebDevToolsAgentPrivate.h:
    (WebDevToolsAgentPrivate):
    * src/WebViewImpl.cpp:
    (WebKit::WebViewImpl::resize):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130015 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    aa967739