Skip to content
  • aestes@apple.com's avatar
    Fix issues found by the Clang Static Analyzer · a872654a
    aestes@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=120230
    
    Reviewed by Darin Adler.
    
    Source/JavaScriptCore:
    
    * API/JSValue.mm:
    (valueToString): Don't leak every CFStringRef when in Objective-C GC.
    * API/ObjCCallbackFunction.mm:
    (JSC::ObjCCallbackFunctionImpl::~ObjCCallbackFunctionImpl): Don't
    release m_invocation's target since NSInvocation will do it for us on
    -dealloc.
    (objCCallbackFunctionForBlock): Tell NSInvocation to retain its target
    and -release our reference to the copied block.
    * API/tests/minidom.c:
    (createStringWithContentsOfFile): Free buffer before returning.
    * API/tests/testapi.c:
    (createStringWithContentsOfFile): Ditto.
    
    Source/WebCore:
    
    * WebCore.xcodeproj/project.pbxproj: Removed FoundationExtras.h.
    * accessibility/mac/WebAccessibilityObjectWrapperMac.mm: Removed CFAutoreleaseHelper().
    (AXTextMarkerRange): Used HardAutorelease() instead of
    CFAutoreleaseHelper().
    (AXTextMarkerRangeStart): Ditto.
    (AXTextMarkerRangeEnd): Ditto.
    (textMarkerForVisiblePosition...
    a872654a