• satish@chromium.org's avatar
    2010-11-18 Satish Sampath <satish@chromium.org> · a739a241
    satish@chromium.org authored
            Reviewed by Jeremy Orlow.
    
            For speech input event, send an event object containing all the recognition results and metadata.
            https://bugs.webkit.org/show_bug.cgi?id=49736
    
            * fast/speech/input-onspeechchange-event-expected.txt: Added.
            * fast/speech/input-onspeechchange-event.html: New test to check multiple results.
            * fast/speech/input-text-language-tag.html: Updated with new method signature.
            * fast/speech/input-text-speechbutton.html: Ditto.
            * fast/speech/speech-button-ignore-generated-events.html: Ditto.
    2010-11-18  Satish Sampath  <satish@chromium.org>
    
            Reviewed by Jeremy Orlow.
    
            For speech input event, send an event object containing all the recognition results and metadata.
            https://bugs.webkit.org/show_bug.cgi?id=49736
    
            Currently the speech input event 'onwebkitspeechchange' receives no parameters. WebCore already
            has the full list of recognition results and populates only the top result into the input field
            automatically. In this patch we pass a SpeechInputEvent object to the event handler, and the JS
            code can access the full list of results via "event.results.length", "results[i].utterance" and
            "results[i].confidence". Also updated mock object with appropriate methods to test multiple results.
    
            Test: fast/speech/input-onspeechchange-event.html
    
            * CMakeLists.txt:
            * GNUmakefile.am:
            * WebCore.gypi:
            * WebCore.pri:
            * WebCore.pro:
            * WebCore.xcodeproj/project.pbxproj:
            * bindings/js/JSEventCustom.cpp:
            (WebCore::toJS): Added new event
            * bindings/v8/custom/V8EventCustom.cpp:
            (WebCore::toV8): Added new event
            * dom/Event.cpp:
            (WebCore::Event::isSpeechInputEvent):
            * dom/Event.h:
            * html/HTMLInputElement.cpp:
            * html/HTMLInputElement.h:
            * page/SpeechInputEvent.h: New file implementing SpeechInputEvent.idl
            (WebCore::SpeechInputEvent::~SpeechInputEvent):
            (WebCore::SpeechInputEvent::create):
            (WebCore::SpeechInputEvent::isSpeechInputEvent):
            (WebCore::SpeechInputEvent::results):
            (WebCore::SpeechInputEvent::SpeechInputEvent):
            * page/SpeechInputEvent.idl: New file defining SpeechInputEvent object
            * page/SpeechInputListener.h:
            * page/SpeechInputResult.cpp:
            (WebCore::SpeechInputResult::create):
            * page/SpeechInputResult.h:
            * page/SpeechInputResult.idl: New file defining a single SpeechInputResult object
            * page/SpeechInputResultList.h: New file implementing SpeechInputResultList.idl
            (WebCore::SpeechInputResultList::create):
            (WebCore::SpeechInputResultList::length):
            (WebCore::SpeechInputResultList::item):
            (WebCore::SpeechInputResultList::SpeechInputResultList):
            * page/SpeechInputResultList.idl: New file defining a list of SpeechInputResult objects
            * platform/mock/SpeechInputClientMock.cpp:
            (WebCore::SpeechInputClientMock::addRecognitionResult): Renamed method and added one parameter.
            (WebCore::SpeechInputClientMock::clearResults):
            (WebCore::SpeechInputClientMock::timerFired):
            * platform/mock/SpeechInputClientMock.h:
            * rendering/TextControlInnerElements.cpp:
            (WebCore::InputFieldSpeechButtonElement::setRecognitionResult): Pass new event object to handler.
    2010-11-18  Satish Sampath  <satish@chromium.org>
    
            Reviewed by Jeremy Orlow.
    
            For speech input event, send an event object containing all the recognition results and metadata.
            https://bugs.webkit.org/show_bug.cgi?id=49736
    
            Updated mock object's method to new signature.
    
            * public/WebSpeechInputControllerMock.h:
            * src/WebSpeechInputControllerMockImpl.cpp:
            (WebKit::WebSpeechInputControllerMockImpl::addMockRecognitionResult):
            * src/WebSpeechInputControllerMockImpl.h:
    2010-11-18  Satish Sampath  <satish@chromium.org>
    
            Reviewed by Jeremy Orlow.
    
            For speech input event, send an event object containing all the recognition results and metadata.
            https://bugs.webkit.org/show_bug.cgi?id=49736
    
            Updated DRT by renaming the mock result method on all platforms to the new signature.
    
            * DumpRenderTree/LayoutTestController.cpp:
            (addMockSpeechInputResultCallback):
            (LayoutTestController::staticFunctions):
            * DumpRenderTree/LayoutTestController.h:
            * DumpRenderTree/chromium/LayoutTestController.cpp:
            (LayoutTestController::LayoutTestController):
            (LayoutTestController::addMockSpeechInputResult):
            * DumpRenderTree/chromium/LayoutTestController.h:
            * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
            (LayoutTestController::addMockSpeechInputResult):
            * DumpRenderTree/mac/LayoutTestControllerMac.mm:
            (LayoutTestController::addMockSpeechInputResult):
            * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
            (LayoutTestController::addMockSpeechInputResult):
            * DumpRenderTree/qt/LayoutTestControllerQt.h:
            * DumpRenderTree/win/LayoutTestControllerWin.cpp:
            (LayoutTestController::addMockSpeechInputResult):
            * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
            (LayoutTestController::addMockSpeechInputResult):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72591 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    a739a241
CMakeLists.txt 68.4 KB