Skip to content
  • zandobersek@gmail.com's avatar
    Unreviewed, rolling out r121058. · a6460e15
    zandobersek@gmail.com authored
    http://trac.webkit.org/changeset/121058
    https://bugs.webkit.org/show_bug.cgi?id=89809
    
    Patch causes plugins tests to crash in GTK debug builds
    (Requested by zdobersek on #webkit).
    
    Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-23
    
    Source/JavaScriptCore: 
    
    * API/APIShims.h:
    (JSC::APIEntryShimWithoutLock::APIEntryShimWithoutLock):
    (JSC::APIEntryShimWithoutLock::~APIEntryShimWithoutLock):
    (APIEntryShimWithoutLock):
    (JSC::APIEntryShim::APIEntryShim):
    (APIEntryShim):
    (JSC::APICallbackShim::~APICallbackShim):
    * API/JSContextRef.cpp:
    (JSGlobalContextCreate):
    (JSGlobalContextCreateInGroup):
    (JSGlobalContextRelease):
    (JSContextCreateBacktrace):
    * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
    * heap/CopiedSpace.cpp:
    (JSC::CopiedSpace::tryAllocateSlowCase):
    * heap/Heap.cpp:
    (JSC::Heap::protect):
    (JSC::Heap::unprotect):
    (JSC::Heap::collect):
    (JSC::Heap::setActivityCallback):
    (JSC::Heap::activityCallback):
    (JSC::Heap::sweeper):
    * heap/Heap.h:
    (Heap):
    * heap/HeapTimer.cpp:
    (JSC::HeapTimer::~HeapTimer):
    (JSC::HeapTimer::invalidate):
    (JSC::HeapTimer::timerDidFire):
    (JSC):
    * heap/HeapTimer.h:
    (HeapTimer):
    * heap/IncrementalSweeper.cpp:
    (JSC::IncrementalSweeper::doWork):
    (JSC::IncrementalSweeper::create):
    * heap/IncrementalSweeper.h:
    (IncrementalSweeper):
    * heap/MarkedAllocator.cpp:
    (JSC::MarkedAllocator::allocateSlowCase):
    * heap/WeakBlock.cpp:
    (JSC::WeakBlock::reap):
    * jsc.cpp:
    (functionGC):
    (functionReleaseExecutableMemory):
    (jscmain):
    * runtime/Completion.cpp:
    (JSC::checkSyntax):
    (JSC::evaluate):
    * runtime/GCActivityCallback.h:
    (DefaultGCActivityCallback):
    (JSC::DefaultGCActivityCallback::create):
    * runtime/JSGlobalData.cpp:
    (JSC::JSGlobalData::JSGlobalData):
    (JSC::JSGlobalData::~JSGlobalData):
    (JSC::JSGlobalData::sharedInstance):
    (JSC::JSGlobalData::sharedInstanceInternal):
    * runtime/JSGlobalData.h:
    (JSGlobalData):
    * runtime/JSGlobalObject.cpp:
    (JSC::JSGlobalObject::~JSGlobalObject):
    (JSC::JSGlobalObject::init):
    * runtime/JSLock.cpp:
    (JSC):
    (JSC::createJSLockCount):
    (JSC::JSLock::lockCount):
    (JSC::setLockCount):
    (JSC::JSLock::JSLock):
    (JSC::JSLock::lock):
    (JSC::JSLock::unlock):
    (JSC::JSLock::currentThreadIsHoldingLock):
    (JSC::JSLock::DropAllLocks::DropAllLocks):
    (JSC::JSLock::DropAllLocks::~DropAllLocks):
    * runtime/JSLock.h:
    (JSC):
    (JSLock):
    (JSC::JSLock::JSLock):
    (JSC::JSLock::~JSLock):
    (DropAllLocks):
    * runtime/WeakGCMap.h:
    (JSC::WeakGCMap::set):
    * testRegExp.cpp:
    (realMain):
    
    Source/WebCore: 
    
    * bindings/js/GCController.cpp:
    (WebCore::collect):
    (WebCore::GCController::garbageCollectSoon):
    (WebCore::GCController::garbageCollectNow):
    (WebCore::GCController::discardAllCompiledCode):
    * bindings/js/JSCustomSQLStatementErrorCallback.cpp:
    (WebCore::JSSQLStatementErrorCallback::handleEvent):
    * bindings/js/JSCustomVoidCallback.cpp:
    (WebCore::JSCustomVoidCallback::handleEvent):
    * bindings/js/JSCustomXPathNSResolver.cpp:
    (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
    * bindings/js/JSErrorHandler.cpp:
    (WebCore::JSErrorHandler::handleEvent):
    * bindings/js/JSEventCustom.cpp:
    (WebCore::toJS):
    * bindings/js/JSEventListener.cpp:
    (WebCore::JSEventListener::handleEvent):
    * bindings/js/JSInjectedScriptHostCustom.cpp:
    (WebCore::InjectedScriptHost::nodeAsScriptValue):
    (WebCore::JSInjectedScriptHost::inspectedObject):
    * bindings/js/JSInjectedScriptManager.cpp:
    (WebCore::InjectedScriptManager::createInjectedScript):
    (WebCore::InjectedScriptManager::canAccessInspectedWindow):
    * bindings/js/JSLazyEventListener.cpp:
    (WebCore::JSLazyEventListener::initializeJSFunction):
    * bindings/js/JSMainThreadExecState.h:
    (WebCore::JSMainThreadExecState::evaluate):
    * bindings/js/JSMutationCallbackCustom.cpp:
    (WebCore::JSMutationCallback::handleEvent):
    * bindings/js/JSNodeFilterCondition.cpp:
    (WebCore::JSNodeFilterCondition::acceptNode):
    * bindings/js/JSRequestAnimationFrameCallbackCustom.cpp:
    (WebCore::JSRequestAnimationFrameCallback::handleEvent):
    * bindings/js/JavaScriptCallFrame.cpp:
    (WebCore::JavaScriptCallFrame::evaluate):
    * bindings/js/PageScriptDebugServer.cpp:
    (WebCore::PageScriptDebugServer::recompileAllJSFunctions):
    * bindings/js/ScheduledAction.cpp:
    (WebCore::ScheduledAction::executeFunctionInContext):
    * bindings/js/ScriptCachedFrameData.cpp:
    (WebCore::ScriptCachedFrameData::ScriptCachedFrameData):
    (WebCore::ScriptCachedFrameData::restore):
    (WebCore::ScriptCachedFrameData::clear):
    * bindings/js/ScriptController.cpp:
    (WebCore::ScriptController::evaluateInWorld):
    (WebCore::ScriptController::clearWindowShell):
    (WebCore::ScriptController::initScript):
    (WebCore::ScriptController::updateDocument):
    (WebCore::ScriptController::cacheableBindingRootObject):
    (WebCore::ScriptController::bindingRootObject):
    (WebCore::ScriptController::windowScriptNPObject):
    (WebCore::ScriptController::jsObjectForPluginElement):
    (WebCore::ScriptController::clearScriptObjects):
    * bindings/js/ScriptControllerMac.mm:
    (WebCore::ScriptController::windowScriptObject):
    * bindings/js/ScriptDebugServer.cpp:
    (WebCore::ScriptDebugServer::dispatchDidPause):
    * bindings/js/ScriptEventListener.cpp:
    (WebCore::eventListenerHandlerBody):
    (WebCore::eventListenerHandlerLocation):
    * bindings/js/ScriptFunctionCall.cpp:
    (WebCore::ScriptCallArgumentHandler::appendArgument):
    (WebCore::ScriptFunctionCall::call):
    (WebCore::ScriptFunctionCall::construct):
    (WebCore::ScriptCallback::call):
    * bindings/js/ScriptObject.cpp:
    (WebCore::ScriptGlobalObject::set):
    (WebCore::ScriptGlobalObject::get):
    (WebCore::ScriptGlobalObject::remove):
    * bindings/js/ScriptValue.cpp:
    (WebCore::ScriptValue::getString):
    (WebCore::ScriptValue::toInspectorValue):
    * bindings/js/WorkerScriptController.cpp:
    (WebCore::WorkerScriptController::~WorkerScriptController):
    (WebCore::WorkerScriptController::initScript):
    (WebCore::WorkerScriptController::evaluate):
    (WebCore::WorkerScriptController::disableEval):
    * bindings/objc/WebScriptObject.mm:
    (_didExecute):
    (-[WebScriptObject _setImp:originRootObject:rootObject:]):
    (-[WebScriptObject _setOriginRootObject:andRootObject:]):
    (-[WebScriptObject dealloc]):
    (-[WebScriptObject finalize]):
    (-[WebScriptObject callWebScriptMethod:withArguments:]):
    (-[WebScriptObject evaluateWebScript:]):
    (-[WebScriptObject setValue:forKey:]):
    (-[WebScriptObject valueForKey:]):
    (-[WebScriptObject removeWebScriptKey:]):
    (-[WebScriptObject hasWebScriptKey:]):
    (-[WebScriptObject stringRepresentation]):
    (-[WebScriptObject webScriptValueAtIndex:]):
    (-[WebScriptObject setWebScriptValueAtIndex:value:]):
    (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
    * bindings/scripts/CodeGeneratorJS.pm:
    (GenerateCallbackImplementation):
    * bindings/scripts/test/JS/JSTestCallback.cpp:
    (WebCore::JSTestCallback::callbackWithNoParam):
    (WebCore::JSTestCallback::callbackWithClass1Param):
    (WebCore::JSTestCallback::callbackWithClass2Param):
    (WebCore::JSTestCallback::callbackWithStringList):
    (WebCore::JSTestCallback::callbackWithBoolean):
    (WebCore::JSTestCallback::callbackRequiresThisToPass):
    * bridge/NP_jsobject.cpp:
    (_NPN_InvokeDefault):
    (_NPN_Invoke):
    (_NPN_Evaluate):
    (_NPN_GetProperty):
    (_NPN_SetProperty):
    (_NPN_RemoveProperty):
    (_NPN_HasProperty):
    (_NPN_HasMethod):
    (_NPN_Enumerate):
    (_NPN_Construct):
    * bridge/c/c_class.cpp:
    (JSC::Bindings::CClass::~CClass):
    (JSC::Bindings::CClass::methodsNamed):
    (JSC::Bindings::CClass::fieldNamed):
    * bridge/c/c_instance.cpp:
    (JSC::Bindings::CInstance::moveGlobalExceptionToExecState):
    (JSC::Bindings::CInstance::invokeMethod):
    (JSC::Bindings::CInstance::invokeDefaultMethod):
    (JSC::Bindings::CInstance::invokeConstruct):
    (JSC::Bindings::CInstance::getPropertyNames):
    * bridge/c/c_runtime.cpp:
    (JSC::Bindings::CField::valueFromInstance):
    (JSC::Bindings::CField::setValueToInstance):
    * bridge/c/c_utility.cpp:
    (JSC::Bindings::convertValueToNPVariant):
    (JSC::Bindings::convertNPVariantToValue):
    * bridge/jni/jni_jsobject.mm:
    (JavaJSObject::call):
    (JavaJSObject::eval):
    (JavaJSObject::getMember):
    (JavaJSObject::setMember):
    (JavaJSObject::removeMember):
    (JavaJSObject::getSlot):
    (JavaJSObject::setSlot):
    (JavaJSObject::toString):
    (JavaJSObject::convertValueToJObject):
    (JavaJSObject::convertJObjectToValue):
    * bridge/jni/jni_objc.mm:
    (JSC::Bindings::dispatchJNICall):
    * bridge/jni/jsc/JNIUtilityPrivate.cpp:
    (JSC::Bindings::convertValueToJValue):
    * bridge/jni/jsc/JavaClassJSC.cpp:
    (JavaClass::JavaClass):
    (JavaClass::~JavaClass):
    * bridge/jni/jsc/JavaInstanceJSC.cpp:
    (JavaInstance::stringValue):
    * bridge/jni/jsc/JavaMethodJSC.cpp:
    (appendClassName):
    (JavaMethod::signature):
    * bridge/jni/jsc/JavaStringJSC.h:
    (JSC::Bindings::JavaString::JavaString):
    (JSC::Bindings::JavaString::~JavaString):
    (JSC::Bindings::JavaString::utf8):
    (JSC::Bindings::JavaString::init):
    * bridge/jsc/BridgeJSC.cpp:
    (JSC::Bindings::Instance::createRuntimeObject):
    (JSC::Bindings::Instance::newRuntimeObject):
    * bridge/objc/objc_instance.mm:
    (ObjcInstance::moveGlobalExceptionToExecState):
    (ObjcInstance::invokeObjcMethod):
    (ObjcInstance::invokeDefaultMethod):
    (ObjcInstance::setValueOfUndefinedField):
    (ObjcInstance::getValueOfUndefinedField):
    * bridge/objc/objc_runtime.mm:
    (JSC::Bindings::ObjcField::valueFromInstance):
    (JSC::Bindings::ObjcField::setValueToInstance):
    * bridge/objc/objc_utility.mm:
    (JSC::Bindings::convertValueToObjcValue):
    (JSC::Bindings::convertNSStringToString):
    (JSC::Bindings::convertObjcValueToValue):
    * bridge/qt/qt_instance.cpp:
    (JSC::Bindings::QtInstance::~QtInstance):
    (JSC::Bindings::QtInstance::getQtInstance):
    (JSC::Bindings::QtInstance::newRuntimeObject):
    * bridge/qt/qt_pixmapruntime.cpp:
    (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):
    * bridge/qt/qt_runtime.cpp:
    (JSC::Bindings::convertValueToQVariant):
    (JSC::Bindings::convertQVariantToValue):
    (JSC::Bindings::QtRuntimeMetaMethod::call):
    (JSC::Bindings::QtRuntimeConnectionMethod::call):
    * bridge/qt/qt_runtime_qt4.cpp:
    (JSC::Bindings::convertValueToQVariant):
    (JSC::Bindings::convertQVariantToValue):
    (JSC::Bindings::QtRuntimeMetaMethod::call):
    (JSC::Bindings::QtRuntimeConnectionMethod::call):
    * html/HTMLCanvasElement.cpp:
    (WebCore::HTMLCanvasElement::createImageBuffer):
    * html/HTMLImageLoader.cpp:
    (WebCore::HTMLImageLoader::notifyFinished):
    * plugins/PluginView.cpp:
    (WebCore::PluginView::start):
    (WebCore::PluginView::stop):
    (WebCore::PluginView::performRequest):
    (WebCore::PluginView::npObject):
    (WebCore::PluginView::privateBrowsingStateChanged):
    * plugins/blackberry/PluginViewBlackBerry.cpp:
    (WebCore::PluginView::dispatchNPEvent):
    (WebCore::PluginView::setNPWindowIfNeeded):
    (WebCore::PluginView::platformStart):
    (WebCore::PluginView::getWindowInfo):
    * plugins/efl/PluginViewEfl.cpp:
    (WebCore::PluginView::dispatchNPEvent):
    * plugins/gtk/PluginViewGtk.cpp:
    (WebCore::PluginView::dispatchNPEvent):
    (WebCore::PluginView::handleKeyboardEvent):
    (WebCore::PluginView::handleMouseEvent):
    (WebCore::PluginView::setNPWindowIfNeeded):
    (WebCore::PluginView::platformStart):
    * plugins/mac/PluginViewMac.mm:
    (WebCore::PluginView::setNPWindowIfNeeded):
    (WebCore::PluginView::dispatchNPEvent):
    * plugins/qt/PluginViewQt.cpp:
    (WebCore::PluginView::dispatchNPEvent):
    (WebCore::PluginView::setNPWindowIfNeeded):
    (WebCore::PluginView::platformStart):
    * plugins/win/PluginViewWin.cpp:
    (WebCore::PluginView::dispatchNPEvent):
    (WebCore::PluginView::handleKeyboardEvent):
    (WebCore::PluginView::handleMouseEvent):
    (WebCore::PluginView::setNPWindowRect):
    * testing/js/WebCoreTestSupport.cpp:
    (WebCoreTestSupport::injectInternalsObject):
    (WebCoreTestSupport::resetInternalsObject):
    * xml/XMLHttpRequest.cpp:
    (WebCore::XMLHttpRequest::dropProtection):
    
    Source/WebKit/blackberry: 
    
    * Api/BlackBerryGlobal.cpp:
    (BlackBerry::WebKit::clearMemoryCaches):
    * WebCoreSupport/ClientExtension.cpp:
    * WebCoreSupport/PagePopupBlackBerry.cpp:
    (WebCore::PagePopupBlackBerry::installDomFunction):
    * WebKitSupport/DumpRenderTreeSupport.cpp:
    (DumpRenderTreeSupport::computedStyleIncludingVisitedInfo):
    
    Source/WebKit/efl: 
    
    * ewk/ewk_frame.cpp:
    (ewk_frame_script_execute):
    * ewk/ewk_view.cpp:
    (ewk_view_js_object_add):
    
    Source/WebKit/gtk: 
    
    * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
    (DumpRenderTreeSupportGtk::gcCountJavascriptObjects):
    
    Source/WebKit/mac: 
    
    * DOM/WebDOMOperations.mm:
    (JSC):
    * Misc/WebCoreStatistics.mm:
    (+[WebCoreStatistics javaScriptObjectsCount]):
    (+[WebCoreStatistics javaScriptGlobalObjectsCount]):
    (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
    (+[WebCoreStatistics javaScriptProtectedGlobalObjectsCount]):
    (+[WebCoreStatistics javaScriptProtectedObjectTypeCounts]):
    (+[WebCoreStatistics javaScriptObjectTypeCounts]):
    (+[WebCoreStatistics shouldPrintExceptions]):
    (+[WebCoreStatistics setShouldPrintExceptions:]):
    (+[WebCoreStatistics memoryStatistics]):
    (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
    * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
    (WebKit::NetscapePluginInstanceProxy::evaluate):
    (WebKit::NetscapePluginInstanceProxy::invoke):
    (WebKit::NetscapePluginInstanceProxy::invokeDefault):
    (WebKit::NetscapePluginInstanceProxy::construct):
    (WebKit::NetscapePluginInstanceProxy::getProperty):
    (WebKit::NetscapePluginInstanceProxy::setProperty):
    (WebKit::NetscapePluginInstanceProxy::removeProperty):
    (WebKit::NetscapePluginInstanceProxy::hasMethod):
    (WebKit::NetscapePluginInstanceProxy::enumerate):
    (WebKit::NetscapePluginInstanceProxy::addValueToArray):
    (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
    * Plugins/WebNetscapePluginStream.mm:
    (WebNetscapePluginStream::wantsAllStreams):
    * Plugins/WebNetscapePluginView.mm:
    (-[WebNetscapePluginView sendEvent:isDrawRect:]):
    (-[WebNetscapePluginView privateBrowsingModeDidChange]):
    (-[WebNetscapePluginView setWindowIfNecessary]):
    (-[WebNetscapePluginView createPluginScriptableObject]):
    (-[WebNetscapePluginView getFormValue:]):
    (-[WebNetscapePluginView evaluateJavaScriptPluginRequest:]):
    (-[WebNetscapePluginView webFrame:didFinishLoadWithReason:]):
    (-[WebNetscapePluginView loadPluginRequest:]):
    (-[WebNetscapePluginView _printedPluginBitmap]):
    * Plugins/WebPluginController.mm:
    (+[WebPluginController plugInViewWithArguments:fromPluginPackage:]):
    (-[WebPluginController stopOnePlugin:]):
    (-[WebPluginController destroyOnePlugin:]):
    (-[WebPluginController startAllPlugins]):
    (-[WebPluginController addPlugin:]):
    * WebView/WebFrame.mm:
    (-[WebFrame _stringByEvaluatingJavaScriptFromString:forceUserGesture:]):
    (-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
    * WebView/WebScriptDebugDelegate.mm:
    (-[WebScriptCallFrame scopeChain]):
    (-[WebScriptCallFrame evaluateWebScript:]):
    * WebView/WebView.mm:
    (+[WebView _reportException:inContext:]):
    (-[WebView aeDescByEvaluatingJavaScriptFromString:]):
    (-[WebView _computedStyleIncludingVisitedInfo:forElement:]):
    
    Source/WebKit/qt: 
    
    * Api/qwebframe.cpp:
    (QWebFramePrivate::addQtSenderToGlobalObject):
    (QWebFrame::addToJavaScriptWindowObject):
    * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
    (DumpRenderTreeSupportQt::injectInternalsObject):
    (DumpRenderTreeSupportQt::resetInternalsObject):
    
    Source/WebKit/win: 
    
    * WebCoreStatistics.cpp:
    (WebCoreStatistics::javaScriptObjectsCount):
    (WebCoreStatistics::javaScriptGlobalObjectsCount):
    (WebCoreStatistics::javaScriptProtectedObjectsCount):
    (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
    (WebCoreStatistics::javaScriptProtectedObjectTypeCounts):
    * WebFrame.cpp:
    (WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
    * WebJavaScriptCollector.cpp:
    (WebJavaScriptCollector::objectCount):
    * WebView.cpp:
    (WebView::stringByEvaluatingJavaScriptFromString):
    (WebView::reportException):
    (WebView::elementFromJS):
    
    Source/WebKit2: 
    
    * Shared/mac/WebMemorySampler.mac.mm:
    (WebKit::WebMemorySampler::sampleWebKit):
    * WebProcess/InjectedBundle/InjectedBundle.cpp:
    (WebKit::InjectedBundle::javaScriptObjectsCount):
    (WebKit::InjectedBundle::reportException):
    * WebProcess/Plugins/Netscape/JSNPObject.cpp:
    (WebKit::JSNPObject::callMethod):
    (WebKit::JSNPObject::callObject):
    (WebKit::JSNPObject::callConstructor):
    (WebKit::JSNPObject::put):
    (WebKit::JSNPObject::deleteProperty):
    (WebKit::JSNPObject::getOwnPropertyNames):
    (WebKit::JSNPObject::propertyGetter):
    * WebProcess/Plugins/Netscape/NPJSObject.cpp:
    (WebKit::NPJSObject::hasMethod):
    (WebKit::NPJSObject::invoke):
    (WebKit::NPJSObject::invokeDefault):
    (WebKit::NPJSObject::hasProperty):
    (WebKit::NPJSObject::getProperty):
    (WebKit::NPJSObject::setProperty):
    (WebKit::NPJSObject::removeProperty):
    (WebKit::NPJSObject::enumerate):
    (WebKit::NPJSObject::construct):
    * WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
    (WebKit::NPRuntimeObjectMap::convertJSValueToNPVariant):
    (WebKit::NPRuntimeObjectMap::evaluate):
    (WebKit::NPRuntimeObjectMap::moveGlobalExceptionToExecState):
    * WebProcess/WebPage/WebFrame.cpp:
    (WebKit::WebFrame::jsWrapperForWorld):
    (WebKit::WebFrame::computedStyleIncludingVisitedInfo):
    * WebProcess/WebPage/WebPage.cpp:
    (WebKit::WebPage::runJavaScriptInMainFrame):
    * WebProcess/WebProcess.cpp:
    (WebKit::WebProcess::getWebCoreStatistics):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@121098 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    a6460e15