-
ch.dumez@sisa.samsung.com authored
https://bugs.webkit.org/show_bug.cgi?id=121390 Reviewed by Darin Adler. Source/WebCore: Set MessageEvent.source to the newly created port for shared workers' connect events instead of previously null, as per the latest specification: http://www.whatwg.org/specs/web-apps/current-work/multipage/comms.html#dom-messageevent-source http://www.whatwg.org/specs/web-apps/current-work/multipage/workers.html#dom-sharedworker This behavior is consisent with Blink. Test: fast/workers/shared-worker-messageevent-source.html * dom/EventTarget.cpp: (WebCore::EventTarget::isMessagePort): * dom/EventTarget.h: * dom/MessageEvent.cpp: (WebCore::isValidSource): (WebCore::MessageEvent::MessageEvent): * dom/MessageEvent.h: Use null String instead of an empty String as default value for origin and lastEventId. This is more efficient and has no impact on the behavior on the JavaScript since a null String is exposed as an empty one on JS side. This change is covered by fast/events/constructors/message-event-constructor.html * dom/MessageEvent.idl: * dom/MessagePort.h: * page/DOMWindow.cpp: (WebCore::PostMessageTimer::event): * workers/SharedWorkerGlobalScope.cpp: (WebCore::createConnectEvent): LayoutTests: Add layout test to check that MessageEvent.source is set to the newly created port for shared workers' connect events. * fast/events/constructors/message-event-constructor-expected.txt: * fast/events/constructors/message-event-constructor.html: * fast/workers/resources/messageevent-source.js: Added. (onconnect): * fast/workers/shared-worker-messageevent-source-expected.txt: Added. * fast/workers/shared-worker-messageevent-source.html: Added. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@155959 268f45cc-cd09-0410-ab3c-d52691b4dbfc
a4654257