Skip to content
  • mario@webkit.org's avatar
    2011-03-29 Mario Sanchez Prada <msanchez@igalia.com> · a420ae1b
    mario@webkit.org authored
            Reviewed by Martin Robinson.
    
            [Gtk] Consistent crash from Google/ARIA combobox click
            https://bugs.webkit.org/show_bug.cgi?id=55883
    
            Added new layout test to check this doesn't crash anymore in GTK.
    
            * platform/gtk/accessibility/aria-options-and-menuitems-crash-expected.txt: Added.
            * platform/gtk/accessibility/aria-options-and-menuitems-crash.html: Added.
    2011-03-29  Mario Sanchez Prada  <msanchez@igalia.com>
    
            Reviewed by Martin Robinson.
    
            [Gtk] Consistent crash from Google/ARIA combobox click
            https://bugs.webkit.org/show_bug.cgi?id=55883
    
            Do not call to firstChild() to avoid entering into infinite loops.
    
            This would happen when current item is a WebCore Group and some of
            its children have either role 'option' or 'menuitem'. Other than
            that the logic behind that call to firstChild() seems to be no
            longer needed so it's safe to remove it.
    
            Test: platform/gtk/accessibility/aria-options-and-menuitems-crash.html
    
            * accessibility/gtk/AccessibilityObjectAtk.cpp:
            (WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):
            Remove call to firsChild, which was leading to crashes sometimes.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@82296 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    a420ae1b