Skip to content
  • jpu@apple.com's avatar
    2011-05-12 Jia Pu <jpu@apple.com> · a2f77992
    jpu@apple.com authored
            Reviewed by Darin Adler.
    
            Regression caused by changeset 86281
            https://bugs.webkit.org/show_bug.cgi?id=60712
    
            Changed wording in some tests to reflect AppKit UI change.
    
            * manual-tests/autocorrection/delete-to-end-of-word-to-show-reversion.html:
            * manual-tests/autocorrection/move-to-end-of-word-to-show-reversion.html:
    2011-05-12  Jia Pu  <jpu@apple.com>
    
            Reviewed by Darin Adler.
    
            Regression caused by changeset 86281
            https://bugs.webkit.org/show_bug.cgi?id=60712
            <rdar://problem/9427970>
    
            Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
            So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
            returns. So we don't need to use the condition to coordinate between these two function. In fact,
            all callbacks are delivered on main thread. We don't really need any locking here.
    
            Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
            been removed.
    
            * WebCoreSupport/CorrectionPanel.h:
            * WebCoreSupport/CorrectionPanel.mm:
            (CorrectionPanel::CorrectionPanel):
            (CorrectionPanel::show):
            (CorrectionPanel::dismiss):
            (CorrectionPanel::dismissInternal):
            (CorrectionPanel::handleAcceptedReplacement):
            * WebCoreSupport/WebEditorClient.mm:
            (WebEditorClient::dismissCorrectionPanelSoon):
    2011-05-12  Jia Pu  <jpu@apple.com>
    
            Reviewed by Darin Adler.
    
            Regression caused by changeset 86281
            https://bugs.webkit.org/show_bug.cgi?id=60712
            <rdar://problem/9427970>
    
            Removed the condition variable. [NSSpellChecker dismissCorrectionIndicatorForView:] is blocking.
            So handleAcceptedReplacement() triggered by dismissInternal() will return before dismissInternal()
            returns. So we don't need to use the condition to coordinate between these two function. In fact,
            all callbacks are delivered on main thread. We don't really need any locking here.
    
            Since now we don't have distinction between dismiss() and dismissSoon(). dismissSoon() has
            been removed.
    
            * UIProcess/API/mac/PageClientImpl.mm:
            (WebKit::PageClientImpl::dismissCorrectionPanelSoon):
            * UIProcess/mac/CorrectionPanel.h:
            * UIProcess/mac/CorrectionPanel.mm:
            (WebKit::CorrectionPanel::CorrectionPanel):
            (WebKit::CorrectionPanel::show):
            (WebKit::CorrectionPanel::dismiss):
            (WebKit::CorrectionPanel::dismissInternal):
            (WebKit::CorrectionPanel::handleAcceptedReplacement):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@86406 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    a2f77992