Skip to content
  • commit-queue@webkit.org's avatar
    Modifying RTCIceCandidate object construction to match the spec · a1366a09
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=124369
    
    Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-15
    Reviewed by Eric Carlson.
    
    According to the spec the RTCIceCandidateInit parameter in RTCSessionDescription constructor is optional,
    which must not be nullable, and, if passed, must be a valid Dictionary. If the keys are not present, the string
    object that stores them in the RTCIceCandidate class, must be null in those cases. Also, if a key is present
    and its value is not valid an exception must be raised.
    
    Source/WebCore:
    
    Existing test was updated.
    
    * GNUmakefile.list.am:
    * Modules/mediastream/RTCIceCandidate.cpp:
    (WebCore::RTCIceCandidate::create):
    * Modules/mediastream/RTCIceCandidate.idl:
    * UseJSC.cmake:
    * WebCore.vcxproj/WebCore.vcxproj:
    * WebCore.vcxproj/WebCore.vcxproj.filters:
    * WebCore.xcodeproj/project.pbxproj:
    * bindings/js/JSRTCIceCandidateCustom.cpp: Added.
    (WebCore::JSRTCIceCandidateConstructor::constructJSRTCIceCandidate):
    
    LayoutTests:
    
    * fast/mediastream/RTCIceCandidate-expected.txt:
    * fast/mediastream/RTCIceCandidate.html:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159349 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    a1366a09