Skip to content
  • morrita@google.com's avatar
    https://bugs.webkit.org/show_bug.cgi?id=85515 · 9da7b7cc
    morrita@google.com authored
    Stale frame in WebCore::SpellChecker::didCheckSucceeded
    
    Source/WebCore:
    
    Reviewed by Ryosuke Niwa.
    
    Added EditorClient::frameWillDetachPage() notification to give a
    change to invalidate pending spellcheck requests on the client.
    
    Test: editing/spelling/spellcheck-async-remove-frame.html
    
    * editing/Editor.cpp:
    (WebCore::Editor::Editor):
    * editing/Editor.h:
    (Editor):
    * loader/EmptyClients.h:
    (WebCore::EmptyEditorClient::frameWillDetachPage):
    * page/EditorClient.h:
    (EditorClient):
    
    Source/WebKit/blackberry:
    
    Reviewed by Ryosuke Niwa.
    
    * WebCoreSupport/EditorClientBlackBerry.h:
    (WebCore::EditorClientBlackBerry::frameWillDetachPage):
    
    Source/WebKit/chromium:
    
    Added WebTextCheckingCompletionImpl::invalidate() to mark
    pending spellcheck request as invalid, and added frameWillDetachPage()
    to fire it.
    
    Reviewed by Ryosuke Niwa.
    
    * src/EditorClientImpl.cpp:
    (WebKit::EditorClientImpl::frameWillDetachPage):
    (WebKit):
    (WebKit::EditorClientImpl::requestCheckingOfString):
    (WebKit::EditorClientImpl::didCheckString):
    * src/EditorClientImpl.h:
    (WebKit):
    (EditorClientImpl):
    * src/WebTextCheckingCompletionImpl.cpp:
    (WebKit::WebTextCheckingCompletionImpl::didFinishCheckingText):
    (WebKit::WebTextCheckingCompletionImpl::didCancelCheckingText):
    (WebKit::WebTextCheckingCompletionImpl::invalidate):
    (WebKit):
    * src/WebTextCheckingCompletionImpl.h:
    (WebKit):
    (WebKit::WebTextCheckingCompletionImpl::WebTextCheckingCompletionImpl):
    (WebTextCheckingCompletionImpl):
    (WebKit::WebTextCheckingCompletionImpl::spellChecker):
    
    Source/WebKit/efl:
    
    Reviewed by Ryosuke Niwa.
    
    * WebCoreSupport/EditorClientEfl.h:
    (WebCore::EditorClientEfl::frameWillDetachPage):
    
    Source/WebKit/gtk:
    
    Reviewed by Ryosuke Niwa.
    
    * WebCoreSupport/EditorClientGtk.h:
    (WebKit::EditorClient::frameWillDetachPage):
    
    Source/WebKit/mac:
    
    Reviewed by Ryosuke Niwa.
    
    * WebCoreSupport/WebEditorClient.h:
    
    Source/WebKit/qt:
    
    Reviewed by Ryosuke Niwa.
    
    * WebCoreSupport/EditorClientQt.h:
    (WebCore::EditorClientQt::frameWillDetachPage):
    
    Source/WebKit/win:
    
    Reviewed by Ryosuke Niwa.
    
    * WebCoreSupport/WebEditorClient.h:
    (WebEditorClient::frameWillDetachPage):
    
    Source/WebKit/wince:
    
    Reviewed by Ryosuke Niwa.
    
    * WebCoreSupport/EditorClientWinCE.h:
    (WebKit::EditorClientWinCE::frameWillDetachPage):
    
    Source/WebKit/wx:
    
    Reviewed by Ryosuke Niwa.
    
    * WebKitSupport/EditorClientWx.h:
    (WebCore::EditorClientWx::frameWillDetachPage):
    
    LayoutTests:
    
    Reviewed by Ryosuke Niwa.
    
    * editing/spelling/spellcheck-async-remove-frame-expected.txt: Added.
    * editing/spelling/spellcheck-async-remove-frame.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@117572 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    9da7b7cc