Skip to content
  • oliver@apple.com's avatar
    2010-03-04 Oliver Hunt <oliver@apple.com> · 9cc43765
    oliver@apple.com authored
            Reviewed by Maciej Stachowiak.
    
            https://bugs.webkit.org/show_bug.cgi?id=35603
            SVG incorrectly allows nested <use> elements in a <use> shadow tree
    
            Simplify the handling of invalid or missing use-targets by cloning them
            to empty <g> elements rather than just allowing the <use> element to
            be copied into the shadow tree, as this violates a number of assumptions
            in the shadow tree handling code.
    
            Tests: svg/custom/use-nested-disallowed-target.svg
                   svg/custom/use-nested-missing-target-added.svg
                   svg/custom/use-nested-missing-target-removed.svg
                   svg/custom/use-nested-missing-target.svg
                   svg/custom/use-nested-notarget.svg
    
            * svg/SVGUseElement.cpp:
            (WebCore::SVGUseElement::buildPendingResource):
            (WebCore::SVGUseElement::buildShadowAndInstanceTree):
            (WebCore::SVGUseElement::expandUseElementsInShadowTree):
    
    2010-03-04  Oliver Hunt  <oliver@apple.com>
    
            Reviewed by Maciej Stachowiak.
    
            https://bugs.webkit.org/show_bug.cgi?id=35603
            SVG incorrectly allows nested <use> elements in a <use> shadow tree
    
            Add test cases for various combinations of <use> and targets that aren't present.
    
            * platform/mac/svg/custom/use-empty-reference-expected.txt: Added.
            * svg/custom/use-nested-disallowed-target-expected.txt: Added.
            * svg/custom/use-nested-disallowed-target.svg: Added.
            * svg/custom/use-nested-missing-target-added-expected.txt: Added.
            * svg/custom/use-nested-missing-target-added.svg: Added.
            * svg/custom/use-nested-missing-target-expected.txt: Added.
            * svg/custom/use-nested-missing-target-removed-expected.txt: Added.
            * svg/custom/use-nested-missing-target-removed.svg: Added.
            * svg/custom/use-nested-missing-target.svg: Added.
            * svg/custom/use-nested-notarget-expected.txt: Added.
            * svg/custom/use-nested-notarget.svg: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@55511 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    9cc43765