Skip to content
  • weinig@apple.com's avatar
    JavaScriptCore: · 9aa392a8
    weinig@apple.com authored
    2008-03-23  Sam Weinig  <sam@webkit.org>
    
            Reviewed by Darin Adler.
    
            Fix http://bugs.webkit.org/show_bug.cgi?id=18048
            The "thisObject" parameter to JSEvaluateScript is not used properly
    
            Making passing a thisObject to JSEvaluateScript actually set the thisObject of the created
            ExecState.
    
            * API/testapi.c:
            (main): Add tests for setting the thisObject when calling JSEvaluateScript.
    
            * kjs/ExecState.cpp:
            (KJS::ExecState::ExecState): Assign the thisObject to m_thisValue and remove the comment. 
    
    WebCore:
    
    2008-03-24  Sam Weinig  <sam@webkit.org>
    
            Reviewed by Darin Adler.
    
            Fix http://bugs.webkit.org/show_bug.cgi?id=18048
            The "thisObject" parameter to JSEvaluateScript is not used properly
    
            * bindings/js/kjs_proxy.cpp:
            (WebCore::KJSProxy::evaluate): No need to pass a thisObject since we want the global object to be used.
            * bridge/jni/jni_jsobject.mm:
            (JavaJSObject::eval): To avoid any change to this function, don't pass a thisObject to keep the same
            behavior.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@31267 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    9aa392a8