Skip to content
  • ch.dumez@sisa.samsung.com's avatar
    Remove custom code for webkitAudioContext global constructor getter · 99856b91
    ch.dumez@sisa.samsung.com authored
    https://bugs.webkit.org/show_bug.cgi?id=116530
    
    Reviewed by Geoffrey Garen.
    
    Source/WebCore:
    
    Get rid of custom code for webkitAudioContext global constructor getter. The
    global DOMWindow attribute is now automatically generated by leveraging support
    for [EnabledAtRuntime] extended attribute and the existing methods in
    RuntimeEnabledFeatures class.
    
    No new tests, no behavior change.
    
    * GNUmakefile.list.am: Remove JSDOMWindowWebAudioCustom.*.
    * Modules/webaudio/AudioContext.idl:
    Remove [NoInterfaceObject] extended attribute so that the global constructor is
    automatically generated instead of automatically added. Add [EnabledAtRuntime]
    extended attribute since this global constructor can be disabled at runtime and
    so that we can getter rid of the [CustomGetter] for the corresponding global
    constructor. Use [InterfaceName] extended attribute so that the interface name
    matches the global constructor on DOMWindow (webkitAudioContext).
    
    * Target.pri: Remove JSDOMWindowWebAudioCustom.*.
    * UseJSC.cmake: Remove JSDOMWindowWebAudioCustom.*.
    * WebCore.exp.in: Export additional symbol.
    * WebCore.order: Export additional symbol.
    * WebCore.vcproj/WebCore.vcproj: Remove JSDOMWindowWebAudioCustom.*.
    * WebCore.vcxproj/WebCore.vcxproj: Remove JSDOMWindowWebAudioCustom.*.
    * WebCore.vcxproj/WebCore.vcxproj.filters: Remove JSDOMWindowWebAudioCustom.*.
    * WebCore.xcodeproj/project.pbxproj: Remove JSDOMWindowWebAudioCustom.*.
    * bindings/generic/RuntimeEnabledFeatures.h:
    (WebCore::RuntimeEnabledFeatures::setWebAudioEnabled):
    * bindings/js/JSBindingsAllInOne.cpp: Remove JSDOMWindowWebAudioCustom.*.
    * bindings/js/JSDOMWindowWebAudioCustom.cpp: Removed. We no longer need any custom code for
    the WebAudio global constructor getter because we use [EnabledAtRuntime] support in the
    bindings generator now.
    * page/DOMWindow.idl: Remove global constructor for AudioContext as it is now automatically
    generated.
    * page/Settings.in: Remove webAudioEnabled setting as we use the existing setting
    in RuntimeEnabledFeatures now.
    
    Source/WebKit/efl:
    
    Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
    
    * WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
    (DumpRenderTreeSupportEfl::setWebAudioEnabled):
    * WebCoreSupport/DumpRenderTreeSupportEfl.h:
    * ewk/ewk_view.cpp:
    (_Ewk_View_Private_Data):
    (_ewk_view_priv_new):
    * ewk/ewk_view.h: Remove public API to toggle Web Audio support as it is no longer
    a view specific feature.
    
    Source/WebKit/gtk:
    
    Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
    
    * webkit/webkitwebview.cpp:
    (webkit_web_view_update_settings):
    (webkit_web_view_settings_notify):
    
    Source/WebKit/mac:
    
    Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
    
    * WebView/WebView.mm:
    (-[WebView _preferencesChanged:]):
    
    Source/WebKit/qt:
    
    Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
    
    * Api/qwebsettings.cpp:
    (QWebSettingsPrivate::apply):
    
    Source/WebKit/win:
    
    Use RuntimeEnabledFeatures instead of Settings to toggle Web Audio support.
    
    * WebView.cpp:
    (WebView::notifyPreferencesChanged):
    
    Source/WebKit2:
    
    Use RuntimeEnabledFeatures instead of WebCore Settings to toggle Web Audio support.
    
    * WebProcess/InjectedBundle/InjectedBundle.cpp:
    (WebKit::InjectedBundle::overrideBoolPreferenceForTestRunner):
    * WebProcess/WebPage/WebPage.cpp:
    (WebKit::WebPage::updatePreferences):
    
    Tools:
    
    Update EFL's DumpRenderTree to use DumpRenderTreeSupport to toggle
    WebAudio feature instead of public ewk_view API since that API was
    removed.
    
    * DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
    (DumpRenderTreeChrome::resetDefaultsToConsistentValues):
    * DumpRenderTree/efl/TestRunnerEfl.cpp:
    (TestRunner::overridePreference):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@150663 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    99856b91