Skip to content
  • tkent@chromium.org's avatar
    Introduce isValidValue(const String&) of HTMLInputElement and HTMLTextAreaElement · 994e7d38
    tkent@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=43537
    
    Reviewed by Darin Adler.
    
    WebCore:
    
    isValidValue() is useful for browser implementations to propose
    form field values without breaking form validity.
    No new tests because these functions are not exposed to JavaScript.
    
    * html/HTMLFormControlElement.h:
    (WebCore::HTMLTextFormControlElement::):
     Remove virtual valueMissing(), patternMismatch(), and tooLong().
    * html/HTMLInputElement.cpp:
    (WebCore::isValidColorString): Moved from ValidityState.
    (WebCore::isValidEmailAddress): ditto.
    (WebCore::HTMLInputElement::isValidValue): Added.
    (WebCore::HTMLInputElement::typeMismatch): Add a String parameter.
    (WebCore::HTMLInputElement::valueMissing): Add a String parameter.
    (WebCore::HTMLInputElement::patternMismatch): Add a String parameter.
    (WebCore::HTMLInputElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
    (WebCore::HTMLInputElement::rangeUnderflow): Add a String parameter.
    (WebCore::HTMLInputElement::rangeOverflow): Add a String parameter.
    (WebCore::HTMLInputElement::stepMismatch): Add a String parameter.
    * html/HTMLInputElement.h:
    * html/HTMLTextAreaElement.cpp:
    (WebCore::HTMLTextAreaElement::tooLong): Add String and NeedsToCheckDirtyFlag parameters.
    (WebCore::HTMLTextAreaElement::isValidValue): Added.
    * html/HTMLTextAreaElement.h:
    (WebCore::HTMLTextAreaElement::valueMissing):
    * html/ValidityState.cpp:
    (WebCore::ValidityState::valueMissing): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
    (WebCore::ValidityState::typeMismatch): Passes value() to HTMLInputElement::typeMismatch().
    (WebCore::ValidityState::patternMismatch): Calls patternMismatch() of HTMLInputElement.
    (WebCore::ValidityState::tooLong): Calls valueMissing() of HTMLInputElement or HTMLTextAreaElement.
    (WebCore::ValidityState::rangeUnderflow): Passes value() to HTMLInputElement::rangeUnderflow().
    (WebCore::ValidityState::rangeOverflow): Passes value() to HTMLInputElement::rangeUnderflow().
    (WebCore::ValidityState::stepMismatch): Passes value() to HTMLInputElement::stepMismatch().
    * html/ValidityState.h:
    
    WebKit/chromium:
    
    * public/WebInputElement.h:
    * src/WebInputElement.cpp:
    (WebKit::WebInputElement::isValidValue):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@66357 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    994e7d38