Skip to content
  • commit-queue@webkit.org's avatar
    Web Inspector: Column Breakpoint not working, may be off by 1 · 979f0e61
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=120334
    
    Patch by Joseph Pecoraro <pecoraro@apple.com> on 2013-08-27
    Reviewed by David Kilzer.
    
    Source/WebCore:
    
    JavaScriptCore changed to 1-based column numbers at some point. We
    need to update the ScriptDebugger assumption that they were 0-based.
    
    Test: inspector-protocol/debugger/column-breakpoint.html
    
    * bindings/js/ScriptDebugServer.cpp:
    (WebCore::ScriptDebugServer::createCallFrame):
    (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
    
    LayoutTests:
    
    Write a protocol test for setting a breakpoint at a line:column.
    
    * inspector-protocol/debugger/column-breakpoint-expected.txt: Added.
    * inspector-protocol/debugger/column-breakpoint.html: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154681 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    979f0e61