Skip to content
  • zimmermann@webkit.org's avatar
    2011-01-25 Nikolas Zimmermann <nzimmermann@rim.com> · 95ccc61b
    zimmermann@webkit.org authored
            Reviewed by Dirk Schulze.
    
            Introduce FontMetrics abstraction
            https://bugs.webkit.org/show_bug.cgi?id=51456
    
            Use accurate floating-point metrics for SVG Font calculations instead of casting float -> integer.
            This hopefully fixes differences between 32/64 bit bots.
    
            Needs new layout test results for several platforms, which need to be taken from the bots landing afterwards.
    
            * platform/graphics/SimpleFontData.cpp:
            (WebCore::SimpleFontData::SimpleFontData):
            (WebCore::SimpleFontData::initCharWidths):
    
    2011-01-25  Nikolas Zimmermann  <nzimmermann@rim.com>
    
            Reviewed by Dirk Schulze.
    
            Introduce FontMetrics abstraction
            https://bugs.webkit.org/show_bug.cgi?id=51456
    
            Update mac/mac-leopard pixel baseline after removing the float -> int truncation in the SVG Fonts ascent/descent calculation code.
    
            * platform/gtk/Skipped: Unskip several tests.
            * platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum:
            * platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
            * platform/mac-leopard/svg/batik/text/textEffect-expected.checksum:
            * platform/mac-leopard/svg/batik/text/textEffect-expected.png:
            * platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum:
            * platform/mac-leopard/svg/batik/text/textEffect3-expected.png:
            * platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum:
            * platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png:
            * platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
            * platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png:
            * platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum:
            * platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png:
            * platform/mac-leopard/svg/text/text-text-05-t-expected.checksum:
            * platform/mac-leopard/svg/text/text-text-05-t-expected.png:
            * platform/mac-leopard/svg/text/text-text-06-t-expected.checksum:
            * platform/mac-leopard/svg/text/text-text-06-t-expected.png:
            * platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt:
            * platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt:
            * platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt:
            * platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt:
            * platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
            * platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
            * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
            * platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
            * platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
            * platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
            * platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
            * platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
            * platform/mac/svg/batik/text/textEffect-expected.txt:
            * platform/mac/svg/batik/text/textEffect3-expected.txt:
            * platform/mac/svg/batik/text/textPosition2-expected.png:
            * platform/mac/svg/batik/text/textPosition2-expected.txt:
            * platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
            * platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
            * platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
            * platform/mac/svg/text/text-text-05-t-expected.txt:
            * platform/mac/svg/text/text-text-06-t-expected.txt:
            * svg/custom/glyph-transformation-with-hkern-expected.txt:
    -This line, and those below, will be ignored--
    
    M    LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.checksum
    M    LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.checksum
    M    LayoutTests/platform/mac-leopard/svg/text/text-text-05-t-expected.png
    M    LayoutTests/platform/mac-leopard/svg/text/text-text-06-t-expected.png
    M    LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png
    M    LayoutTests/platform/mac-leopard/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.checksum
    M    LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.checksum
    M    LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.checksum
    M    LayoutTests/platform/mac-leopard/svg/batik/text/textEffect-expected.png
    M    LayoutTests/platform/mac-leopard/svg/batik/text/textEffect3-expected.png
    M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.png
    M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.checksum
    M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.checksum
    M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-without-missing-glyph-expected.checksum
    M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-with-no-element-reference-expected.png
    M    LayoutTests/platform/mac-leopard/svg/custom/svg-fonts-in-html-expected.png
    M    LayoutTests/platform/mac/svg/text/text-text-06-t-expected.txt
    M    LayoutTests/platform/mac/svg/text/text-text-05-t-expected.txt
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-05-t-expected.txt
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-text-06-t-expected.txt
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png
    M    LayoutTests/platform/mac/svg/batik/text/textEffect3-expected.txt
    M    LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.png
    M    LayoutTests/platform/mac/svg/batik/text/textEffect-expected.txt
    M    LayoutTests/platform/mac/svg/batik/text/textPosition2-expected.txt
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt
    M    LayoutTests/platform/mac/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt
    M    LayoutTests/platform/mac/svg/custom/svg-fonts-in-html-expected.txt
    M    LayoutTests/platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt
    M    LayoutTests/platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt
    M    LayoutTests/platform/gtk/Skipped
    M    LayoutTests/ChangeLog
    M    LayoutTests/svg/custom/glyph-transformation-with-hkern-expected.txt
    M    Source/WebCore/ChangeLog
    M    Source/WebCore/platform/graphics/SimpleFontData.cpp
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76586 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    95ccc61b