Skip to content
  • zandobersek@gmail.com's avatar
    [GTK][NRWT] Lower timeout value to 6 seconds (12 for debug configuration) · 935800a9
    zandobersek@gmail.com authored
    https://bugs.webkit.org/show_bug.cgi?id=96506
    
    Reviewed by Dirk Pranke.
    
    Tools: 
    
    Lower the timeout value to 6 seconds for release configuration and 12 seconds
    for debug configuration. These are the same values the Chromium port uses.
    
    Currently the value is lowered only for the DumpRenderTree, WebKitTestRunner (and
    the layout tests under WebKit2 generally) requires more attention and gardening
    than what the current effort produces.
    
    The unit test is updated as well to test these changes.
    
    * Scripts/webkitpy/layout_tests/port/gtk.py:
    (GtkPort.default_timeout_ms):
    * Scripts/webkitpy/layout_tests/port/gtk_unittest.py:
    (GtkPortTest.test_default_timeout_ms):
    (GtkPortTest.assertLinesEqual):
    
    LayoutTests: 
    
    Create a new section for slow tests. Tests listed here pass (or at least
    work as expected or reliably) but require more than 6 or 12 seconds to run.
    
    More tests are added into the timeout section. These are primarily tests
    that used to take half a minute to run just to be interrupted by the watchdog
    in DumpRenderTree and were then reported as text mismatch failures. Now they
    will be timing out which is (arguably) a more proper way for them to fail.
    
    * platform/gtk/TestExpectations:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@128414 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    935800a9