Skip to content
  • commit-queue@webkit.org's avatar
    ASSERT(time.isFinite()) in SVGSMILElement::createInstanceTimesFromSyncbase · 909a2e9a
    commit-queue@webkit.org authored
    <https://webkit.org/b/108184>
    
    Patch by Tamas Gergely <tgergely.u-szeged@partner.samsung.com> on 2014-01-21
    Reviewed by Philip Rogers.
    
    Source/WebCore:
    
    In the case a SMILElement timing had a syncbase dependency on an indefinite value
    the assert were raised. The assert has been removed and a check has been added
    instead that prevents the addition of indefinite times to the time list.
    
    Test: svg/animations/smil-syncbase-self-dependency.svg
    
    * svg/animation/SVGSMILElement.cpp:
    (WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
      ASSERT removed.
    
    LayoutTests:
    
    Test checks whether valid self-dependency is accidentally broken.
    
    * svg/animations/smil-syncbase-self-dependency-expected.txt: Added.
    * svg/animations/smil-syncbase-self-dependency.svg: Added.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@162459 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    909a2e9a