• ap@apple.com's avatar
    Layout Test http/tests/security/canvas-remote-read-remote-image-redirect.html is flaky · 8fa93cc1
    ap@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=121458
    
    Reviewed by Sam Weinig.
    
    Source/WebCore:
    
    The code to automagically produce line numbers is quite fragile. Added some FIXMEs,
    and added an issue that was making reporting flaky for code is JS event handlers
    executed while parsing was paused.
    
    * page/PageConsole.cpp: (WebCore::PageConsole::addMessage): Use actual "script is
    running" check instead of "parsing a script element" one.
    
    LayoutTests:
    
    * fast/frames/sandboxed-iframe-attribute-parsing-06-expected.txt:
    * fast/frames/sandboxed-iframe-attribute-parsing-07-expected.txt:
    * fast/frames/sandboxed-iframe-attribute-parsing-08-expected.txt:
    * fast/frames/sandboxed-iframe-attribute-parsing-09-expected.txt:
    * fast/frames/sandboxed-iframe-attribute-parsing-10-expected.txt:
    * fast/frames/sandboxed-iframe-attribute-parsing-11-expected.txt:
    * fast/frames/sandboxed-iframe-attribute-parsing-12-expected.txt:
    * fast/frames/sandboxed-iframe-attribute-parsing-13-expected.txt:
    * fast/frames/sandboxed-iframe-attribute-parsing-14-expected.txt:
    * fast/frames/sandboxed-iframe-parsing-space-characters-expected.txt:
    * fast/frames/sandboxed-iframe-scripting-04-expected.txt:
    * http/tests/security/contentSecurityPolicy/sandbox-empty-expected.txt:
    * http/tests/security/contentSecurityPolicy/sandbox-empty-subframe-expected.txt:
    * http/tests/security/contentSecurityPolicy/sandbox-in-http-header-control-expected.txt:
    * http/tests/security/contentSecurityPolicy/sandbox-in-http-header-expected.txt:
    * http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt:
    * http/tests/security/isolatedWorld/sandboxed-iframe-expected.txt:
    * media/video-controls-no-scripting-expected.txt:
    We now get a line number for blocked inline scripts, which is a progression.
    It is the line number for the closing </script>, which is not ideal, but better
    than nothing.
    
    * http/tests/security/mixedContent/insecure-script-in-iframe-expected.txt:
    * http/tests/security/mixedContent/redirect-http-to-https-script-in-iframe-expected.txt:
    Also a progression - we now get a line number for offending <script>.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156130 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    8fa93cc1
PageConsole.cpp 7.08 KB