Skip to content
  • jpu@apple.com's avatar
    2012-04-05 Jia Pu <jpu@apple.com> · 8d2f68b0
    jpu@apple.com authored
            Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
            https://bugs.webkit.org/show_bug.cgi?id=82970
    
            Reviewed by Enrica Casucci.
    
            Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
            See WebCore/ChangeLog for details.
    
            * UIProcess/API/gtk/PageClientImpl.cpp:
            * UIProcess/API/mac/PageClientImpl.h:
            (PageClientImpl):
            * UIProcess/API/mac/PageClientImpl.mm:
            (WebKit::PageClientImpl::recordAutocorrectionResponse):
            * UIProcess/API/qt/qquickwebview.cpp:
            * UIProcess/PageClient.h:
            (PageClient):
            * UIProcess/WebPageProxy.cpp:
            (WebKit::WebPageProxy::recordAutocorrectionResponse):
            * UIProcess/mac/CorrectionPanel.h:
            * UIProcess/mac/CorrectionPanel.mm:
            * WebKit2.xcodeproj/project.pbxproj:
            * WebProcess/WebCoreSupport/mac/WebAlternativeTextClient.cpp: Added.
            (WebKit):
            (WebKit::WebAlternativeTextClient::WebAlternativeTextClient):
            (WebKit::WebAlternativeTextClient::~WebAlternativeTextClient):
            (WebKit::WebAlternativeTextClient::showCorrectionAlternative):
            (WebKit::WebAlternativeTextClient::dismissAlternative):
            (WebKit::WebAlternativeTextClient::dismissAlternativeSoon):
            (WebKit::WebAlternativeTextClient::recordAutocorrectionResponse):
            * WebProcess/WebCoreSupport/WebAlternativeTextClient.h: Added.
            (WebKit):
            (WebAlternativeTextClient):
            * WebProcess/WebCoreSupport/WebEditorClient.h:
            * WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:
            (WebKit):
            * WebProcess/WebPage/WebPage.cpp:
            (WebKit::WebPage::WebPage):
    
    2012-04-05  Jia Pu  <jpu@apple.com>
    
            Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
            https://bugs.webkit.org/show_bug.cgi?id=82970
    
            Reviewed by Enrica Casucci.
    
            Move correction panel related functions from WebEditorClient to the new WebAlternativeTextClient.
            See WebCore/ChangeLog for details.
    
            * WebCoreSupport/CorrectionPanel.h:
            * WebCoreSupport/CorrectionPanel.mm:
            * WebCoreSupport/WebAlternativeTextClient.h: Added.
            (WebAlternativeTextClient):
            * WebCoreSupport/WebAlternativeTextClient.mm: Added.
            (WebAlternativeTextClient::WebAlternativeTextClient):
            (WebAlternativeTextClient::~WebAlternativeTextClient):
            (WebAlternativeTextClient::showCorrectionAlternative):
            (WebAlternativeTextClient::dismissAlternative):
            (WebAlternativeTextClient::dismissAlternativeSoon):
            (WebAlternativeTextClient::recordAutocorrectionResponse):
            * WebCoreSupport/WebEditorClient.h:
            * WebCoreSupport/WebEditorClient.mm:
            (WebEditorClient::~WebEditorClient):
            * WebView/WebView.mm:
            (-[WebView _commonInitializationWithFrameName:groupName:]):
    
    2012-04-05  Jia Pu  <jpu@apple.com>
    
            Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
            https://bugs.webkit.org/show_bug.cgi?id=82970
    
            Reviewed by Enrica Casucci.
    
            See WebCore/ChangeLog for details.
    
            * WebKit.xcodeproj/project.pbxproj:
    
    2012-04-05  Jia Pu  <jpu@apple.com>
    
            Move correction panel related functions from EditorClient into separated AlternativeTextClient class.
            https://bugs.webkit.org/show_bug.cgi?id=82970
    
            Reviewed by Enrica Casucci.
    
            No new tests, since there's no change of functionality.
    
            The existing correction panel related functions in EditorClient are currently used only by OS X.
            We'd like to move them into separate AlternativeTextClient class to avoid using #ifdef's. This
            new client class will also hold dictation alternative related interface that we will add soon for
            bug 82503.
    
            * WebCore.vcproj/WebCore.vcproj:
            * WebCore.xcodeproj/project.pbxproj:
            * editing/AlternativeTextController.cpp: Changes in this file are all for calling functions in
              AlternativeTextClient instead of those in EditoClient.
            (WebCore::AlternativeTextController::show):
            (WebCore::AlternativeTextController::dismiss):
            (WebCore::AlternativeTextController::dismissSoon):
            (WebCore::AlternativeTextController::respondToUnappliedSpellCorrection):
            (WebCore::AlternativeTextController::timerFired):
            (WebCore::AlternativeTextController::isAutomaticSpellingCorrectionEnabled):
            (WebCore::AlternativeTextController::alternativeTextClient):
            (WebCore):
            (WebCore::AlternativeTextController::editorClient):
            (WebCore::AlternativeTextController::textChecker):
            (WebCore::AlternativeTextController::recordAutocorrectionResponseReversed):
            (WebCore::AlternativeTextController::recordSpellcheckerResponseForModifiedCorrection):
            * editing/AlternativeTextController.h:
            (WebCore):
            (AlternativeTextController):
            * editing/TextCheckingHelper.h:
            (WebCore):
            * loader/EmptyClients.h:
            (EmptyEditorClient):
            * page/AlternativeTextClient.h: Added.
            (WebCore):
            (AlternativeTextClient):
            (WebCore::AlternativeTextClient::~AlternativeTextClient):
            * page/EditorClient.h:
            (EditorClient):
            * page/Page.cpp:
            (WebCore::Page::Page):
            (WebCore::Page::PageClients::PageClients):
            * page/Page.h:
            (WebCore):
            (PageClients):
            (Page):
            (WebCore::Page::alternativeTextClient):
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@113340 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    8d2f68b0