Skip to content
  • ojan@chromium.org's avatar
    Table layout does not need to explicitly call computePreferredLogicalWidths · 8cdbcc91
    ojan@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=106931
    
    Reviewed by Julien Chaffraix.
    
    Code shouldn't need to explicitly call computePreferredLogicalWidths.
    It should only get called as a by-product of calling minPreferredLogicalWidth
    or maxPreferredLogicalWidth.
    
    Instead, make it clear that the calling code is just trying to clear
    preferred width dirty bits.
    
    * rendering/AutoTableLayout.cpp:
    (WebCore::AutoTableLayout::recalcColumn):
    The computePreferredLogicalWidths call on the table cell is redundant
    with the minPreferredLogicalWidth call on the next line.
    
    * rendering/FixedTableLayout.cpp:
    (WebCore::FixedTableLayout::calcWidthArray):
    We only need to clear the dirty bit here. Table cells don't use
    their preferred widths in fixed table layout calculations.
    
    * rendering/RenderTableCell.h:
    * rendering/RenderTableCol.cpp:
    (WebCore::RenderTableCol::clearPreferredLogicalWidthsDirtyBits):
    * rendering/RenderTableCol.h:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@140047 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    8cdbcc91