Skip to content
  • adamk@chromium.org's avatar
    Remove no-op StorageNamespace::unlock method · 89bf0b74
    adamk@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=72181
    
    Reviewed by Darin Adler.
    
    Source/WebCore:
    
    The method was meant to support the localStorage mutex,
    but the approach of using a mutex for localStorage has never been
    implemented (and almost certainly won't be). Even if it were implemented,
    it's not being called at the right time, due to bugs in the V8 bindings'
    use of V8Proxy (see http://webkit.org/b/72063 for details).
    
    If, in the future, some replacement for a mutex is used to synchronize
    localStorage access, it can easily be re-added to the (hopefully
    fixed-by-then) replacement for V8Proxy::didLeaveScriptContext.
    
    * bindings/v8/V8Proxy.cpp:
    (WebCore::V8Proxy::didLeaveScriptContext): Stop calling unlock().
    * page/Navigator.cpp:
    (WebCore::Navigator::getStorageUpdates): Remove implementation (a call to unlock), but leave code as it's exposed to the platform.
    * page/Navigator.idl: Added a FIXME to remove getStorageUpdates from the platform.
    * storage/StorageNamespace.h:
    * storage/StorageNamespaceImpl.cpp:
    * storage/StorageNamespaceImpl.h:
    
    Source/WebKit/chromium:
    
    * src/StorageNamespaceProxy.cpp:
    * src/StorageNamespaceProxy.h:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100041 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    89bf0b74