Skip to content
  • commit-queue@webkit.org's avatar
    Move CSS3 text decoration implementation behind ENABLE(CSS3_TEXT_DECORATION) · 897022bd
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=123541
    
    Patch by Myles C. Maxfield <mmaxfield@apple.com> on 2013-10-31
    Reviewed by Tim Horton.
    
    Source/WebCore:
    
    Enabled CSS3 text decoration tests
    
    * css/CSSComputedStyleDeclaration.cpp:
    (WebCore::renderTextDecorationStyleFlagsToCSSValue): Mapping internal
    representation to a CSSValue
    (WebCore::ComputedStyleExtractor::propertyValue): Ditto
    * css/CSSParser.cpp: Moving parsing functions behind new flag
    (WebCore::isColorPropertyID):
    (WebCore::CSSParser::parseValue):
    (WebCore::CSSParser::addTextDecorationProperty):
    (WebCore::CSSParser::parseTextDecorationSkip):
    (WebCore::CSSParser::parseTextUnderlinePosition):
    * css/CSSParser.h:
    * css/CSSPrimitiveValueMappings.h:
    * css/CSSPropertyNames.in: Marking the new properties behind new flag
    * css/CSSValueKeywords.in: Marking new values behind new flag
    * css/DeprecatedStyleBuilder.cpp:
    (WebCore::DeprecatedStyleBuilder::DeprecatedStyleBuilder):
    * css/StylePropertyShorthand.cpp:
    (WebCore::shorthandForProperty): Move text decoration shorthand
    (WebCore::matchingShorthandsForLonghand):
    * css/StylePropertyShorthand.h:
    * css/StyleResolver.cpp:
    (WebCore::isValidVisitedLinkProperty):
    (WebCore::StyleResolver::applyProperty):
    * platform/graphics/GraphicsContext.h:
    * platform/graphics/cairo/GraphicsContextCairo.cpp:
    (WebCore::GraphicsContext::setPlatformStrokeStyle):
    * platform/graphics/cg/GraphicsContextCG.cpp:
    (WebCore::GraphicsContext::drawLine):
    * platform/graphics/wince/GraphicsContextWinCE.cpp:
    (WebCore::createPen):
    * rendering/InlineFlowBox.cpp:
    * rendering/InlineFlowBox.h:
    * rendering/InlineTextBox.cpp:
    (WebCore::textDecorationStyleToStrokeStyle):
    (WebCore::computeUnderlineOffset):
    (WebCore::InlineTextBox::paintDecoration):
    * rendering/RenderObject.cpp:
    (WebCore::decorationColor):
    * rendering/RootInlineBox.cpp:
    * rendering/RootInlineBox.h:
    * rendering/style/RenderStyle.cpp:
    (WebCore::RenderStyle::changeRequiresRepaintIfTextOrBorderOrOutline):
    (WebCore::RenderStyle::colorIncludingFallback):
    (WebCore::RenderStyle::visitedDependentColor):
    * rendering/style/RenderStyle.h:
    * rendering/style/RenderStyleConstants.h:
    * rendering/style/StyleRareInheritedData.cpp:
    (WebCore::StyleRareInheritedData::StyleRareInheritedData):
    (WebCore::StyleRareInheritedData::operator==):
    * rendering/style/StyleRareInheritedData.h:
    * rendering/style/StyleRareNonInheritedData.cpp:
    (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
    (WebCore::StyleRareNonInheritedData::operator==):
    * rendering/style/StyleRareNonInheritedData.h:
    
    LayoutTests:
    
    * platform/mac/TestExpectations: Enable CSS3 text decoration tests
    (since CSS3_TEXT_DECORATION is enabled by default)
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@158389 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    897022bd