Skip to content
  • carlosgc@webkit.org's avatar
    2011-06-14 Carlos Garcia Campos <cgarcia@igalia.com> · 85bd6c10
    carlosgc@webkit.org authored
            Reviewed by Martin Robinson.
    
            [GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
            https://bugs.webkit.org/show_bug.cgi?id=62626
    
            The method actually converts coordinates, the rectangle size is
            not affected, so it can be modified to return a point
            instead. Fix also a bug in the implementation, it was translating
            the coordinates twice returning the wrong position when the given
            rectangle was not at 0,0.
    
            * platform/gtk/GtkUtilities.cpp:
            (WebCore::convertWidgetPointToScreenPoint):
            * platform/gtk/GtkUtilities.h:
            * platform/gtk/PopupMenuGtk.cpp:
            (WebCore::PopupMenuGtk::show): Use
            convertWidgetPointToScreenPoint().
    2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
    
            Reviewed by Martin Robinson.
    
            [GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
            https://bugs.webkit.org/show_bug.cgi?id=62626
    
            * WebCoreSupport/ChromeClientGtk.cpp:
            (WebKit::ChromeClient::windowToScreen): Update to use
            convertWidgetPointToScreenPoint()
            (WebKit::ChromeClient::screenToWindow): Ditto.
            * webkit/webkitwebview.cpp: Remove globalPointForClientPoint()
            since it does the same than convertWidgetPointToScreenPoint().
            (webkit_web_view_popup_menu_handler): Use
            convertWidgetPointToScreenPoint() instead of globalPointForClientPoint().
            (doDragLeaveLater): Ditto.
            (webkit_web_view_drag_motion): Ditto.
            (webkit_web_view_drag_data_received): Ditto.
            (webkit_web_view_drag_drop): Ditto.
    2011-06-14  Carlos Garcia Campos  <cgarcia@igalia.com>
    
            Reviewed by Martin Robinson.
    
            [GTK] Rename convertWidgetRectToScreenRect() to convertWidgetPointToScreenPoint()
            https://bugs.webkit.org/show_bug.cgi?id=62626
    
            * UIProcess/API/gtk/PageClientImpl.cpp:
            (WebKit::PageClientImpl::screenToWindow): Implement this method
            using convertWidgetPointToScreenPoint().
            (WebKit::PageClientImpl::windowToScreen): Update to use
            convertWidgetPointToScreenPoint().
            * UIProcess/gtk/WebPopupMenuProxyGtk.cpp:
            (WebKit::WebPopupMenuProxyGtk::showPopupMenu): Use
            convertWidgetPointToScreenPoint().
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@88802 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    85bd6c10