Skip to content
  • jianli@chromium.org's avatar
    Intermittent crash in fast/files/read-blob-async.html on the GTK+ debug · 859b5489
    jianli@chromium.org authored
    bots
    https://bugs.webkit.org/show_bug.cgi?id=53104
    
    Reviewed by David Levin.
    
    Source/WebCore:
    
    Covered by the existing tests.
    
    * fileapi/FileStreamProxy.cpp:
    (WebCore::FileStreamProxy::startOnFileThread):
    * platform/network/BlobRegistryImpl.cpp:
    (WebCore::BlobRegistryImpl::createResourceHandle):
    * platform/network/BlobResourceHandle.cpp:
    (WebCore::BlobResourceHandle::BlobResourceHandle):
    (WebCore::BlobResourceHandle::cancel):
    (WebCore::delayedStartBlobResourceHandle):
    (WebCore::BlobResourceHandle::start): Keep BlobResourceHandle alive
    till the delay function is called.
    (WebCore::BlobResourceHandle::doStart):
    (WebCore::doNotifyFinish):
    (WebCore::BlobResourceHandle::notifyFinish): Notify the client via the
    standalone function to prevent the handle from being disposed immediately
    by the client which will make the calls in the stack that're still bound
    to the handle suffer.
    * platform/network/BlobResourceHandle.h:
    * platform/network/ResourceHandle.h: Change cancel() to virtual so that
    BlobResourceHandle::cancel will be called when we abort a FileReader.
    
    LayoutTests:
    
    * platform/gtk/Skipped: Enable the flakey test that has been fixed.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@77852 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    859b5489