-
commit-queue@webkit.org authored
Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Updated expected results after the change that syncs the WebKit isEditable and WebCore isContentEditable. * platform/mac/editing/selection/designmode-no-caret-expected.txt: 2011-02-28 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Frame::isContentEditable is currently based on two things: Editor::clientIsEditable and Document::inDesignMode. In fact, it should only rely on Document::inDesignMode. As a result, Editor::clientIsEditable and its client-side implementation can be removed. * WebCore.exp.in: * accessibility/AccessibilityRenderObject.cpp: (WebCore::AccessibilityRenderObject::isReadOnly): * editing/Editor.cpp: * editing/Editor.h: * editing/SelectionController.cpp: (WebCore::SelectionController::setSelectionFromNone): * html/HTMLElement.cpp: (WebCore::HTMLElement::isContentEditable): (WebCore::HTMLElement::isContentRichlyEditable): * page/DragController.cpp: (WebCore::DragController::operationForLoad): * page/EditorClient.h: * page/Frame.cpp: * page/Frame.h: 2011-02-28 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Remove the WebKit side implementation. * src/EditorClientImpl.cpp: * src/EditorClientImpl.h: 2011-02-28 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Remove the WebKit side implementation. * WebCoreSupport/EditorClientEfl.cpp: * WebCoreSupport/EditorClientEfl.h: 2011-02-28 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode. * WebCoreSupport/EditorClientGtk.cpp: * WebCoreSupport/EditorClientGtk.h: * webkit/webkitwebview.cpp: (webkit_web_view_init): (webkit_web_view_get_editable): (webkit_web_view_set_editable): * webkit/webkitwebviewprivate.h: 2011-02-28 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Remove the WebKit side implementation. * WebCoreSupport/EditorClientHaiku.cpp: * WebCoreSupport/EditorClientHaiku.h: 2011-02-28 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode. * WebCoreSupport/WebEditorClient.h: * WebCoreSupport/WebEditorClient.mm: * WebView/WebView.mm: (-[WebView setEditable:]): (-[WebView isEditable]): * WebView/WebViewData.h: 2011-02-28 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode. * Api/qwebpage.cpp: (QWebPagePrivate::QWebPagePrivate): (QWebPage::setContentEditable): (QWebPage::isContentEditable): * Api/qwebpage_p.h: * WebCoreSupport/EditorClientQt.cpp: * WebCoreSupport/EditorClientQt.h: 2011-02-28 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Remove the WebKit side implementation. * WebCoreSupport/WebEditorClient.cpp: * WebCoreSupport/WebEditorClient.h: 2011-02-28 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Remove the WebKit side implementation. * WebCoreSupport/EditorClientWinCE.cpp: * WebCoreSupport/EditorClientWinCE.h: 2011-02-28 Chang Shu <cshu@webkit.org> Reviewed by Ryosuke Niwa. Remove the support of Frame::isContentEditable and its dependencies. https://bugs.webkit.org/show_bug.cgi?id=54292 Remove the WebKit side implementation. Make WebKit support depend on Document::inDesignMode. * WebFrame.cpp: (wxWebFrame::wxWebFrame): (wxWebFrame::MakeEditable): (wxWebFrame::IsEditable): * WebFrame.h: * WebKitSupport/EditorClientWx.cpp: * WebKitSupport/EditorClientWx.h: * WebView.cpp: (wxWebView::wxWebView): * WebView.h: git-svn-id: http://svn.webkit.org/repository/webkit/trunk@79953 268f45cc-cd09-0410-ab3c-d52691b4dbfc
83c267fc