Skip to content
  • sergio@webkit.org's avatar
    Calling nativeImageForCurrentFrame() causes assertion failure: m_verifier.isSafeToUse() · 7f2de901
    sergio@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=67582
    
    Reviewed by David Levin.
    
    Source/WebCore:
    
    Added a new synchronous method to the IconDatabase that returns a
    native image for the platform instead of a WebCore::Image*.
    
    * loader/icon/IconDatabase.cpp:
    (WebCore::IconDatabase::synchronousNativeIconForPageURL):
    (WebCore):
    * loader/icon/IconDatabase.h:
    (IconDatabase):
    * loader/icon/IconDatabaseBase.h:
    (WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
    (IconDatabaseBase):
    
    Source/WebKit/blackberry:
    
    Use synchronousNativeIconForPageURL() to retrieve favicons.
    
    * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
    (WebCore::FrameLoaderClientBlackBerry::dispatchDidReceiveIcon):
    
    Source/WebKit/cf:
    
    Fixes windows build.
    
    * WebCoreSupport/WebInspectorClientCF.cpp:
    
    Source/WebKit/efl:
    
    Use synchronousNativeIconForPageURL() to retrieve favicons.
    
    * ewk/ewk_history.cpp:
    (ewk_history_item_icon_surface_get):
    (ewk_history_item_icon_object_add):
    * ewk/ewk_settings.cpp:
    (ewk_settings_icon_database_icon_surface_get):
    (ewk_settings_icon_database_icon_object_add):
    
    Source/WebKit/gtk:
    
    Use synchronousNativeIconForPageURL() to retrieve favicons.
    
    * webkit/webkitfavicondatabase.cpp:
    (getIconPixbufSynchronously):
    
    Source/WebKit/qt:
    
    Use synchronousNativeIconForPageURL() to retrieve favicons.
    
    * Api/qwebhistory.cpp:
    (QWebHistoryItem::icon):
    * Api/qwebsettings.cpp:
    (QWebSettings::iconForUrl):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@120694 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    7f2de901