Skip to content
  • eric.carlson@apple.com's avatar
    2009-08-03 Eric Carlson <eric.carlson@apple.com> · 7d12a642
    eric.carlson@apple.com authored
            Reviewed by Eric Seidel.
    
            HTMLInputElement is not controllable by assistive technologies
            https://bugs.webkit.org/show_bug.cgi?id=27941
    
            Test: accessibility/input-slider.html
    
            * WebCore.xcodeproj/project.pbxproj:
                Add AccessibilitySlider.cpp/.h
    
            * accessibility/AXObjectCache.cpp:
            (WebCore::AXObjectCache::getOrCreate):
                Create AccessibilitySlider and AccessibilitySliderThumb.
    
            * accessibility/AccessibilityObject.h:
            (WebCore::AccessibilityObject::increment):
            (WebCore::AccessibilityObject::decrement):
                Add default, do nothing, base class methods.
    
            * accessibility/AccessibilityRenderObject.cpp:
            (WebCore::AccessibilityRenderObject::canSetFocusAttribute):
                Correct typo.
    
            * accessibility/AccessibilitySlider.cpp: Added.
            (WebCore::AccessibilitySlider::AccessibilitySlider):
            (WebCore::AccessibilitySlider::create):
            (WebCore::AccessibilitySlider::children):
            (WebCore::AccessibilitySlider::addChildren):
            (WebCore::AccessibilitySlider::getAttribute):
            (WebCore::AccessibilitySlider::valueForRange):
            (WebCore::AccessibilitySlider::maxValueForRange):
            (WebCore::AccessibilitySlider::minValueForRange):
            (WebCore::AccessibilitySlider::changeValue):
            (WebCore::AccessibilitySlider::setValue):
            (WebCore::AccessibilitySlider::increment):
            (WebCore::AccessibilitySlider::decrement):
            (WebCore::AccessibilitySlider::element):
            (WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb):
            (WebCore::AccessibilitySliderThumb::create):
            (WebCore::AccessibilitySliderThumb::elementRect):
            (WebCore::AccessibilitySliderThumb::size):
            * accessibility/AccessibilitySlider.h: Added.
            (WebCore::AccessibilitySlider::~AccessibilitySlider):
            (WebCore::AccessibilitySlider::roleValue):
            (WebCore::AccessibilitySlider::accessibilityIsIgnored):
            (WebCore::AccessibilitySlider::isSlider):
            (WebCore::AccessibilitySlider::canSetValueAttribute):
            (WebCore::AccessibilitySliderThumb::~AccessibilitySliderThumb):
            (WebCore::AccessibilitySliderThumb::roleValue):
            (WebCore::AccessibilitySliderThumb::accessibilityIsIgnored):
            (WebCore::AccessibilitySliderThumb::setParentObject):
            (WebCore::AccessibilitySliderThumb::parentObject):
    
            * accessibility/mac/AccessibilityObjectWrapper.mm:
            (RoleEntry::):
                SliderThumbRole -> NSAccessibilityValueIndicatorRole
            (-[AccessibilityObjectWrapper roleDescription]):
                Return role description for NSAccessibilitySliderRole and NSAccessibilityValueIndicatorRole.
            (-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
                Minor coding style correction.
            (-[AccessibilityObjectWrapper accessibilityPerformPressAction]):
                If attachement view handles press action, don't also call object wrapper.
            (-[AccessibilityObjectWrapper accessibilityPerformIncrementAction]):
                New, call object's increment() method.
            (-[AccessibilityObjectWrapper accessibilityPerformDecrementAction]):
                New, call object's decrement() method.
            (-[AccessibilityObjectWrapper accessibilityPerformAction:]):
                Respond to NSAccessibilityIncrementAction and NSAccessibilityDecrementAction.
    
            * rendering/RenderSlider.cpp:
            (WebCore::RenderSlider::thumbRect):
                Factor logic out of layout so AccessibilitySliderThumb can get thumb location/size.
            (WebCore::RenderSlider::layout):
                Move code to thumbRect().
            * rendering/RenderSlider.h:
    
    2009-08-03  Eric Carlson  <eric.carlson@apple.com>
    
            Reviewed by Eric Seidel.
    
            HTMLInputElement is not controllable by assistive technologies
            https://bugs.webkit.org/show_bug.cgi?id=27941
    
            Accessibility control of a slider required adding increment() and decrement()
            methods to AccessibilityObject, so expose thos methods on AccessibilityUIElement.
    
            * DumpRenderTree/AccessibilityUIElement.cpp:
            (incrementCallback): New, call UI element increment method.
            (decrementCallback): New, call UI element decrement method.
            (AccessibilityUIElement::getJSClass): Expose increment and decrement methods.
    
            * DumpRenderTree/AccessibilityUIElement.h:
            * DumpRenderTree/mac/AccessibilityUIElementMac.mm:
            (AccessibilityUIElement::increment): New, send NSAccessibilityIncrementAction to Mac wrapper.
            (AccessibilityUIElement::decrement): New, send NSAccessibilityDecrementAction to Mac wrapper.
    
            * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
            (AccessibilityUIElement::increment): New, do nothing.
            (AccessibilityUIElement::decrement): New, do nothing.
    
    2009-08-03  Eric Carlson  <eric.carlson@apple.com>
    
            Reviewed by Eric Seidel.
    
            HTMLInputElement is not controllable by assistive technologies
            https://bugs.webkit.org/show_bug.cgi?id=27941
            
            Add test for <input type=range> accessibility .
    
            * accessibility/input-slider.html: Added.
            * platform/mac/accessibility/input-slider-expected.txt: Added.
    
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@46720 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    7d12a642