• mrobinson@webkit.org's avatar
    2010-11-24 Martin Robinson <mrobinson@igalia.com> · 7cc9eaf2
    mrobinson@webkit.org authored
            Reviewed by Xan Lopez.
    
            [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
            https://bugs.webkit.org/show_bug.cgi?id=49143
    
            Unskip passing editing tests.
    
            * platform/gtk/Skipped:
            * platform/gtk/Skipped.rej: Added.
            * platform/gtk/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
            * platform/gtk/editing/deleting/delete-3608430-fix-expected.txt:
            * platform/gtk/editing/deleting/delete-3608445-fix-expected.txt:
            * platform/gtk/editing/deleting/delete-3608462-fix-expected.txt:
            * platform/gtk/editing/deleting/delete-3775172-fix-expected.txt:
            * platform/gtk/editing/deleting/delete-3800834-fix-expected.txt:
            * platform/gtk/editing/deleting/delete-3959464-fix-expected.txt:
            * platform/gtk/editing/deleting/delete-and-undo-expected.txt:
            * platform/gtk/editing/deleting/delete-block-contents-001-expected.txt:
            * platform/gtk/editing/deleting/delete-block-contents-002-expected.txt:
            * platform/gtk/editing/deleting/delete-block-contents-003-expected.txt:
            * platform/gtk/editing/deleting/delete-block-merge-contents-010-expected.txt:
            * platform/gtk/editing/deleting/delete-block-merge-contents-012-expected.txt:
            * platform/gtk/editing/deleting/delete-block-merge-contents-013-expected.txt:
            * platform/gtk/editing/deleting/delete-block-merge-contents-014-expected.txt:
            * platform/gtk/editing/deleting/delete-block-merge-contents-015-expected.txt:
            * platform/gtk/editing/deleting/delete-block-merge-contents-016-expected.txt:
            * platform/gtk/editing/deleting/delete-block-merge-contents-017-expected.txt:
            * platform/gtk/editing/deleting/delete-br-001-expected.txt:
            * platform/gtk/editing/deleting/delete-br-002-expected.txt:
            * platform/gtk/editing/deleting/delete-br-003-expected.txt:
            * platform/gtk/editing/deleting/delete-br-004-expected.txt:
            * platform/gtk/editing/deleting/delete-br-005-expected.txt:
            * platform/gtk/editing/deleting/delete-br-006-expected.txt:
            * platform/gtk/editing/deleting/delete-br-007-expected.txt:
            * platform/gtk/editing/deleting/delete-br-010-expected.txt:
            * platform/gtk/editing/deleting/delete-contiguous-ws-001-expected.txt:
            * platform/gtk/editing/deleting/delete-image-004-expected.txt:
            * platform/gtk/editing/deleting/delete-leading-ws-001-expected.txt:
            * platform/gtk/editing/deleting/delete-line-001-expected.txt:
            * platform/gtk/editing/deleting/delete-line-002-expected.txt:
            * platform/gtk/editing/deleting/delete-line-005-expected.txt:
            * platform/gtk/editing/deleting/delete-line-006-expected.txt:
            * platform/gtk/editing/deleting/delete-line-007-expected.txt:
            * platform/gtk/editing/deleting/delete-line-008-expected.txt:
            * platform/gtk/editing/deleting/delete-line-009-expected.txt:
            * platform/gtk/editing/deleting/delete-line-010-expected.txt:
            * platform/gtk/editing/deleting/delete-line-011-expected.txt:
            * platform/gtk/editing/deleting/delete-line-012-expected.txt:
            * platform/gtk/editing/deleting/delete-line-013-expected.txt:
            * platform/gtk/editing/deleting/delete-line-014-expected.txt:
            * platform/gtk/editing/deleting/delete-line-end-ws-001-expected.txt:
            * platform/gtk/editing/deleting/delete-line-end-ws-002-expected.txt:
            * platform/gtk/editing/deleting/delete-listitem-001-expected.txt:
            * platform/gtk/editing/deleting/delete-listitem-002-expected.txt:
            * platform/gtk/editing/deleting/delete-select-all-002-expected.txt:
            * platform/gtk/editing/deleting/delete-tab-002-expected.txt:
            * platform/gtk/editing/deleting/delete-tab-004-expected.txt:
            * platform/gtk/editing/deleting/delete-to-end-of-paragraph-expected.txt:
            * platform/gtk/editing/deleting/delete-to-select-table-expected.txt:
            * platform/gtk/editing/deleting/delete-trailing-ws-002-expected.txt:
            * platform/gtk/editing/deleting/delete-ws-fixup-001-expected.txt:
            * platform/gtk/editing/deleting/delete-ws-fixup-002-expected.txt:
            * platform/gtk/editing/deleting/forward-delete-expected.txt:
            * platform/gtk/editing/deleting/smart-delete-003-expected.txt:
            * platform/gtk/editing/deleting/smart-delete-004-expected.txt:
            * platform/gtk/editing/execCommand/4641880-1-expected.txt: Added.
            * platform/gtk/editing/execCommand/4641880-2-expected.txt: Added.
            * platform/gtk/editing/execCommand/create-list-with-hr-expected.txt: Added.
            * platform/gtk/editing/execCommand/find-after-replace-expected.txt: Added.
            * platform/gtk/editing/execCommand/findString-2-expected.txt: Added.
            * platform/gtk/editing/execCommand/findString-diacriticals-expected.txt: Added.
            * platform/gtk/editing/execCommand/findString-expected.txt: Added.
            * platform/gtk/editing/execCommand/format-block-with-trailing-br-expected.txt: Added.
            * platform/gtk/editing/execCommand/indent-empty-root-expected.txt: Added.
            * platform/gtk/editing/execCommand/indent-list-item-expected.txt: Added.
            * platform/gtk/editing/execCommand/indent-paragraphs-expected.txt: Removed.
            * platform/gtk/editing/execCommand/indent-selection-expected.txt: Added.
            * platform/gtk/editing/execCommand/insert-list-and-stitch-expected.txt: Added.
            * platform/gtk/editing/execCommand/insertHorizontalRule-expected.txt: Added.
            * platform/gtk/editing/execCommand/insertImage-expected.txt: Added.
            * platform/gtk/editing/execCommand/nsresponder-indent-expected.txt: Added.
            * platform/gtk/editing/execCommand/nsresponder-outdent-expected.txt: Added.
            * platform/gtk/editing/execCommand/outdent-blockquote-test1-expected.txt: Added.
            * platform/gtk/editing/execCommand/outdent-blockquote-test2-expected.txt: Added.
            * platform/gtk/editing/execCommand/outdent-blockquote-test3-expected.txt: Added.
            * platform/gtk/editing/execCommand/outdent-blockquote-test4-expected.txt: Added.
            * platform/gtk/editing/execCommand/outdent-selection-expected.txt: Added.
            * platform/gtk/editing/execCommand/paste-1-expected.txt: Added.
            * platform/gtk/editing/execCommand/paste-2-expected.txt: Added.
            * platform/gtk/editing/execCommand/remove-list-from-range-selection-expected.txt: Added.
            * platform/gtk/editing/execCommand/remove-list-item-1-expected.txt: Added.
            * platform/gtk/editing/execCommand/selectAll-expected.txt: Added.
            * platform/gtk/editing/inserting/insert-3654864-fix-expected.txt:
            * platform/gtk/editing/inserting/insert-3775316-fix-expected.txt:
            * platform/gtk/editing/inserting/insert-3800346-fix-expected.txt:
            * platform/gtk/editing/inserting/insert-3851164-fix-expected.txt:
            * platform/gtk/editing/inserting/insert-3907422-fix-expected.txt:
            * platform/gtk/editing/inserting/insert-after-delete-001-expected.txt:
            * platform/gtk/editing/inserting/insert-br-005-expected.txt:
            * platform/gtk/editing/inserting/insert-div-001-expected.txt:
            * platform/gtk/editing/inserting/insert-div-002-expected.txt:
            * platform/gtk/editing/inserting/insert-div-003-expected.txt:
            * platform/gtk/editing/inserting/insert-div-004-expected.txt:
            * platform/gtk/editing/inserting/insert-div-005-expected.txt:
            * platform/gtk/editing/inserting/insert-div-009-expected.txt:
            * platform/gtk/editing/inserting/insert-div-024-expected.txt:
            * platform/gtk/editing/inserting/insert-space-in-empty-doc-expected.txt:
            * platform/gtk/editing/inserting/insert-text-with-newlines-expected.txt:
            * platform/gtk/editing/inserting/redo-expected.txt:
            * platform/gtk/editing/inserting/typing-001-expected.txt:
            * platform/gtk/editing/inserting/typing-002-expected.txt:
            * platform/gtk/editing/inserting/typing-003-expected.txt:
            * platform/gtk/editing/inserting/typing-around-br-001-expected.txt:
            * platform/gtk/editing/inserting/typing-around-image-001-expected.txt:
            * platform/gtk/editing/pasteboard/4076267-2-expected.txt:
            * platform/gtk/editing/pasteboard/4076267-3-expected.txt:
            * platform/gtk/editing/pasteboard/4076267-expected.txt:
            * platform/gtk/editing/pasteboard/5368833-expected.txt: Added.
            * platform/gtk/editing/pasteboard/cut-text-001-expected.txt:
            * platform/gtk/editing/pasteboard/drag-drop-dead-frame-expected.txt:
            * platform/gtk/editing/pasteboard/drag-drop-modifies-page-expected.txt:
            * platform/gtk/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
            * platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
            * platform/gtk/editing/pasteboard/paste-text-001-expected.txt:
            * platform/gtk/editing/pasteboard/paste-text-002-expected.txt:
            * platform/gtk/editing/pasteboard/paste-text-003-expected.txt:
            * platform/gtk/editing/pasteboard/paste-text-004-expected.txt:
            * platform/gtk/editing/pasteboard/paste-text-005-expected.txt:
            * platform/gtk/editing/pasteboard/paste-text-006-expected.txt:
            * platform/gtk/editing/pasteboard/paste-text-007-expected.txt:
            * platform/gtk/editing/pasteboard/paste-text-008-expected.txt:
            * platform/gtk/editing/pasteboard/paste-text-009-expected.txt:
            * platform/gtk/editing/pasteboard/paste-text-010-expected.txt:
            * platform/gtk/editing/pasteboard/paste-text-013-expected.txt: Added.
            * platform/gtk/editing/pasteboard/paste-text-015-expected.txt:
            * platform/gtk/editing/pasteboard/paste-xml-expected.txt:
            * platform/gtk/editing/pasteboard/subframe-dragndrop-1-expected.txt:
            * platform/gtk/editing/selection/4889598-expected.txt:
            * platform/gtk/editing/selection/4947387-expected.txt: Added.
            * platform/gtk/editing/selection/5195166-2-expected.txt: Added.
            * platform/gtk/editing/selection/extend-by-character-002-expected.txt:
            * platform/gtk/editing/selection/extend-by-character-003-expected.txt:
            * platform/gtk/editing/selection/extend-by-character-004-expected.txt:
            * platform/gtk/editing/selection/extend-by-character-005-expected.txt:
            * platform/gtk/editing/selection/extend-selection-bidi-expected.txt: Added.
            * platform/gtk/editing/selection/fake-drag-expected.txt:
            * platform/gtk/editing/selection/iframe-expected.txt:
            * platform/gtk/editing/selection/inline-table-expected.txt:
            * platform/gtk/editing/selection/move-backwords-by-word-001-expected.txt:
            * platform/gtk/editing/selection/move-between-blocks-no-001-expected.txt:
            * platform/gtk/editing/selection/move-between-blocks-yes-001-expected.txt:
            * platform/gtk/editing/selection/move-by-character-001-expected.txt:
            * platform/gtk/editing/selection/move-by-character-002-expected.txt:
            * platform/gtk/editing/selection/move-by-character-003-expected.txt:
            * platform/gtk/editing/selection/move-by-character-004-expected.txt:
            * platform/gtk/editing/selection/move-by-character-005-expected.txt:
            * platform/gtk/editing/selection/move-by-sentence-001-expected.txt:
            * platform/gtk/editing/selection/move-past-trailing-space-expected.txt:
            * platform/gtk/editing/selection/select-box-expected.txt:
            * platform/gtk/editing/selection/selection-actions-expected.txt:
            * platform/gtk/editing/spelling/spelling-expected.txt:
            * platform/gtk/editing/style/block-style-003-expected.txt:
            * platform/gtk/editing/style/relative-font-size-change-001-expected.txt:
            * platform/gtk/editing/style/style-3681552-fix-001-expected.txt:
            * platform/gtk/editing/style/style-3681552-fix-002-expected.txt:
            * platform/gtk/editing/style/typing-style-001-expected.txt:
            * platform/gtk/editing/style/typing-style-002-expected.txt:
            * platform/gtk/editing/style/unbold-in-bold-expected.txt:
            * platform/gtk/editing/undo/4063751-expected.txt:
            * platform/gtk/editing/undo/redo-typing-001-expected.txt:
            * platform/gtk/editing/undo/undo-combined-delete-boundary-expected.txt:
            * platform/gtk/editing/undo/undo-combined-delete-expected.txt:
            * platform/gtk/editing/undo/undo-delete-boundary-expected.txt:
            * platform/gtk/editing/undo/undo-delete-expected.txt:
            * platform/gtk/editing/undo/undo-forward-delete-boundary-expected.txt:
            * platform/gtk/editing/undo/undo-forward-delete-expected.txt:
            * platform/gtk/editing/undo/undo-misspellings-expected.txt:
    2010-11-24  Martin Robinson  <mrobinson@igalia.com>
    
            Reviewed by Xan Lopez.
    
            [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
            https://bugs.webkit.org/show_bug.cgi?id=49143
    
            * platform/gtk/GtkVersioning.c:
            (g_signal_accumulator_first_wins): Add g_signal_accumulator_first_wins for versions of
            GLib before 2.28.
            * platform/gtk/GtkVersioning.h:
    2010-11-24  Martin Robinson  <mrobinson@igalia.com>
    
            Reviewed by Xan Lopez.
    
            [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
            https://bugs.webkit.org/show_bug.cgi?id=49143
    
            Add signals that encapsulate the functionality of the Mac EditingDelegate. These signals
            are private for now, but DRT consumes them to produce proper output for editing tests.
            After some time, these may be part of the public API.
    
            * WebCoreSupport/EditorClientGtk.cpp:
            (WebKit::EditorClient::shouldDeleteRange): Fire the appropriate editing signal.
            (WebKit::EditorClient::shouldShowDeleteInterface): Ditto.
            (WebKit::EditorClient::shouldBeginEditing): Ditto.
            (WebKit::EditorClient::shouldEndEditing): Ditto.
            (WebKit::kit): Added helper function.
            (WebKit::EditorClient::shouldInsertText): Fire the appropriate editing signal.
            (WebKit::EditorClient::shouldChangeSelectedRange): Ditto.
            (WebKit::EditorClient::shouldApplyStyle): Ditto.
            (WebKit::EditorClient::didBeginEditing): Ditto.
            (WebKit::EditorClient::respondToChangedContents): Ditto.
            (WebKit::EditorClient::respondToChangedSelection): Ditto.
            (WebKit::EditorClient::didEndEditing): Ditto.
            (WebKit::EditorClient::shouldInsertNode): Ditto.
            * webkit/webkitwebview.cpp:
            (webkit_web_view_real_should_allow_editing_action): Added this default signal
            callback which explicitly allows cancellable editing actions.
            (webkit_web_view_class_init): Add new editing signal declarations to the view.
            * webkit/webkitwebview.h:
            * webkitmarshal.list: Added some new marshaling definitions.
    2010-11-24  Martin Robinson  <mrobinson@igalia.com>
    
            Reviewed by Xan Lopez.
    
            [GTK] The WebKitWebView should expose a set of signals encapsulating the behavior of the EditorClient
            https://bugs.webkit.org/show_bug.cgi?id=49143
    
            * DumpRenderTree/gtk/DumpRenderTree.cpp:
            (createWebView): Call the new connectEditingCallbacks function.
            * DumpRenderTree/gtk/EditingCallbacks.cpp: Added.
            (dumpNodePath):
            (dumpRange):
            (insertActionString):
            (selectionAffinityString):
            (shouldBeginEditing):
            (shouldEndEditing):
            (shouldInsertNode):
            (shouldInsertText):
            (shouldDeleteRange):
            (shouldShowDeleteInterfaceForElement):
            (shouldChangeSelectedRange):
            (shouldApplyStyle):
            (editingBegan):
            (userChangedContents):
            (editingEnded):
            (selectionChanged):
            (connectEditingCallbacks):
            * DumpRenderTree/gtk/EditingCallbacks.h: Added.
            * GNUmakefile.am: Added EditingCallbacks.{h,cpp} to the source list.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@72675 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    7cc9eaf2
Skipped 213 KB