Skip to content
  • dgrogan@chromium.org's avatar
    IndexedDB: Improve error messages · 7948a89c
    dgrogan@chromium.org authored
    https://bugs.webkit.org/show_bug.cgi?id=104624
    
    Reviewed by Tony Chang.
    
    Source/WebCore:
    
    Add detail to error messages so that they are more helpful and can be
    traced back to a specific line of code.
    
    Updated test: transaction-error.html
    
    * Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
    (WebCore::IDBDatabaseBackendImpl::CreateObjectStoreOperation::perform):
    (WebCore::IDBDatabaseBackendImpl::DeleteObjectStoreOperation::perform):
    (WebCore::IDBDatabaseBackendImpl::VersionChangeOperation::perform):
    (WebCore::IDBDatabaseBackendImpl::openConnection):
    (WebCore::IDBDatabaseBackendImpl::openConnectionWithVersion):
    (WebCore::IDBDatabaseBackendImpl::deleteDatabase):
    (WebCore::IDBDatabaseBackendImpl::close):
    * Modules/indexeddb/IDBFactoryBackendImpl.cpp:
    (WebCore::IDBFactoryBackendImpl::getDatabaseNames):
    (WebCore::IDBFactoryBackendImpl::deleteDatabase):
    (WebCore::IDBFactoryBackendImpl::open):
    * Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
    (WebCore::IDBObjectStoreBackendImpl::setIndexKeys):
    (WebCore::IDBObjectStoreBackendImpl::createIndex):
    (WebCore::IDBObjectStoreBackendImpl::CreateIndexOperation::perform):
    * Modules/indexeddb/IDBTransactionBackendImpl.cpp:
    (WebCore::IDBTransactionBackendImpl::abort):
    (WebCore::IDBTransactionBackendImpl::commit):
    
    LayoutTests:
    
    Updated error message and establish that non-ascii characters in index
    names don't make it back to the browser properly.
    
    * storage/indexeddb/resources/shared.js:
    (unexpectedAbortCallback):
    * storage/indexeddb/resources/transaction-error.js:
    (testErrorFromCommit.trans.oncomplete.request.onupgradeneeded.trans.onabort):
    (testErrorFromCommit.trans.oncomplete.request.onupgradeneeded):
    (testErrorFromCommit.trans.oncomplete):
    (testErrorFromCommit):
    * storage/indexeddb/transaction-error-expected.txt:
    * storage/indexeddb/transaction-error.html:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@137635 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    7948a89c