Skip to content
  • commit-queue@webkit.org's avatar
    filter: drop-shadow doesnot support viewport units · 786d0398
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=122053
    
    Patch by Gurpreet Kaur <k.gurpreet@samsung.com> on 2013-09-28
    Reviewed by Darin Adler.
    
    Source/WebCore:
    
    drop-shadow properties were not applied incase its values
    were given in vh, vw, vmax, vmin units.
    
    Tests: fast/css/drop-shadow-viewport-height.html
           fast/css/drop-shadow-viewport-vmax.html
           fast/css/drop-shadow-viewport-vmin.html
           fast/css/drop-shadow-viewport-width.html
    
    * css/StyleResolver.cpp:
    (WebCore::StyleResolver::createFilterOperations):
    Calculating the drop-shadow values which has been specified in viewport
    units.The vh/vw units are calcultated as percent of viewport height and
    viewport width respectively. 1vmax: 1vw or 1vh, whatever is largest.
    1vmin: 1vw or 1vh, whatever is smallest.
    
    LayoutTests:
    
    * fast/css/drop-shadow-viewport-height-expected-mismatch.html: Added.
    * fast/css/drop-shadow-viewport-height.html: Added.
    * fast/css/drop-shadow-viewport-vmax-expected-mismatch.html: Added.
    * fast/css/drop-shadow-viewport-vmax.html: Added.
    * fast/css/drop-shadow-viewport-vmin-expected-mismatch.html: Added.
    * fast/css/drop-shadow-viewport-vmin.html: Added.
    * fast/css/drop-shadow-viewport-width-expected-mismatch.html: Added.
    * fast/css/drop-shadow-viewport-width.html: Added.
    Added new tests for verifying that drop-shadow properties are applied
    when its values are viewport units.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@156606 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    786d0398