Skip to content
  • haraken@chromium.org's avatar
    [JSC] REGRESSION(r122912): CodeGeneratorJS.pm should not · 729c9636
    haraken@chromium.org authored
    implicitly assume ScriptExecutionContext for static attributes
    https://bugs.webkit.org/show_bug.cgi?id=91924
    
    Reviewed by Adam Barth.
    
    r122912 implemented static attributes in CodeGeneratorJS.pm.
    However, the generated code assumes that static attributes
    always require ScriptExecutionContext, which is wrong.
    If we need a ScriptExecutionContext, we should specify
    [CallWith=ScriptExecutionContext].
    
    This patch fixes CodeGeneratorJS.pm so that static attributes
    do not assume ScriptExecutionContext. This fix aligns with
    the fix in CodeGeneratorV8.pm in r123308.
    
    Test: bindings/scripts/test/TestObj.idl
    
    * bindings/scripts/CodeGeneratorJS.pm:
    (GenerateImplementation):
    * bindings/scripts/test/JS/JSTestInterface.cpp:
    (WebCore::jsTestInterfaceConstructorSupplementalStaticReadOnlyAttr):
    (WebCore::jsTestInterfaceConstructorSupplementalStaticAttr):
    (WebCore::setJSTestInterfaceConstructorSupplementalStaticAttr):
    * bindings/scripts/test/JS/JSTestObj.cpp:
    (WebCore::jsTestObjConstructorStaticReadOnlyIntAttr):
    (WebCore::jsTestObjConstructorStaticStringAttr):
    (WebCore::setJSTestObjConstructorStaticStringAttr):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123433 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    729c9636