Skip to content
  • ggaren@apple.com's avatar
    Refactored WeakBlock to use malloc, clarify behavior · 7070d420
    ggaren@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=87318
    
    Reviewed by Filip Pizlo.
    
    We want to use malloc so we can make these smaller than 4KB,
    since an individual MarkedBlock will usually have fewer than
    4KB worth of weak pointers.
    
    * heap/Heap.cpp:
    (JSC::Heap::markRoots): Renamed visitLiveWeakImpls to visit, since
    we no longer need to distinguish from "visitDeadWeakImpls".
    
    Renamed "visitDeadWeakImpls" to "reap" because we're not actually
    doing any visiting -- we're just tagging things as dead.
    
    * heap/WeakBlock.cpp:
    (JSC::WeakBlock::create):
    (JSC::WeakBlock::destroy):
    (JSC::WeakBlock::WeakBlock): Malloc!
    
    (JSC::WeakBlock::visit):
    (JSC::WeakBlock::reap): Renamed as above.
    
    * heap/WeakBlock.h:
    (WeakBlock): Reduced to 3KB, as explained above.
    
    * heap/WeakSet.cpp:
    (JSC::WeakSet::visit):
    (JSC::WeakSet::reap):
    * heap/WeakSet.h:
    (WeakSet): Updated for renames, and to match WebKit style.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@118269 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    7070d420