Skip to content
  • sergio@webkit.org's avatar
    [CSS Grid Layout] Handle 'span' positions during layout · 6fa74132
    sergio@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=119756
    
    Reviewed by Andreas Kling.
    
    From Blink r149133 by <jchaffraix@chromium.org>
    
    Source/WebCore:
    
    Properly handle the 'span' keyword during layout. We only had
    parsing support so far but with this change we are able to
    recognize these positions and act accordingly.
    
    * rendering/RenderGrid.cpp:
    (WebCore::RenderGrid::resolveGridPositionsFromStyle):
    (WebCore::RenderGrid::resolveGridPositionAgainstOppositePosition):
    * rendering/RenderGrid.h:
    * rendering/style/GridPosition.h:
    (WebCore::GridPosition::shouldBeResolvedAgainstOppositePosition):
    
    LayoutTests:
    
    Added some new test cases to verify that we properly resolve
    'span' positions.
    
    * fast/css-grid-layout/grid-item-negative-position-resolution-expected.txt:
    * fast/css-grid-layout/grid-item-negative-position-resolution.html:
    * fast/css-grid-layout/grid-item-spanning-resolution-expected.txt:
    * fast/css-grid-layout/grid-item-spanning-resolution.html:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@154753 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    6fa74132