• dino@apple.com's avatar
    Track menu needs localization · 6a507318
    dino@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=105233
    
    Reviewed by Eric Carlson.
    
    Source/WebCore:
    
    Allow the UI strings in the closed captions menu to be localized, and
    profile strings for the English locale.
    
    Test: media/video-controls-captions-trackmenu-localized.html
    
    * English.lproj/Localizable.strings: Adds the four new captions strings.
    * html/shadow/MediaControlElements.cpp:
    (WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Use localized getters.
    * platform/LocalizedStrings.cpp:
    (WebCore::textTrackClosedCaptionsText): New localized string getter.
    (WebCore::textTrackSubtitlesText): Ditto.
    (WebCore::textTrackOffText): Ditto.
    (WebCore::textTrackNoLabelText): Ditto.
    * platform/LocalizedStrings.h:
    
    LayoutTests:
    
    Test to exercise the localization of strings in the captions menu.
    While I was here I merged some common code into a helper file.
    
    * media/trackmenu-test.js: Added. New helper file to run common test operations.
    * media/video-controls-captions-trackmenu-localized-expected.txt: Added.
    * media/video-controls-captions-trackmenu-localized.html: Added.
    * media/video-controls-captions-trackmenu-sorted.html: Updated to use helper functions.
    * platform/chromium/TestExpectations: Skip unimplemented test.
    * platform/efl/TestExpectations: Ditto.
    * platform/gtk/TestExpectations: Ditto.
    * platform/qt/TestExpectations: Ditto.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@138071 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    6a507318
video-controls-captions-trackmenu-localized.html 2.59 KB