Skip to content
  • jchaffraix@webkit.org's avatar
    Add the needed plumbing to parse display: -webkit-grid · 63c7d1af
    jchaffraix@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=72331
    
    Reviewed by Tony Chang.
    
    Source/WebCore:
    
    Test: fast/css-grid-layout/display-grid-set-get.html
    
    Added parsing support for display: -webkit-grid. From a rendering perspective,
    the value is equivalent to display: none until we properly implement it.
    
    * css/CSSParser.cpp:
    (WebCore::CSSParser::parseValue):
    * css/CSSPrimitiveValueMappings.h:
    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
    * css/CSSValueKeywords.in:
    * rendering/style/RenderStyleConstants.h:
    Added the new CSS value and plumbed the parsing and style application of
    the new value.
    
    * css/CSSPrimitiveValueMappings.h:
    (WebCore::CSSPrimitiveValue::operator EDisplay):
    Added an ASSERT here as I bumped into some non-trivial issues due to bug 72296.
    -wap-marquee was offsetting the new value and was wrongly casted by the CSSPrimitiveValueMapping
    logic outside the EDisplay range which would lead to crashes.
    
    * rendering/RenderObject.cpp:
    (WebCore::RenderObject::createObject):
    Fixed the indentation to follow our coding rules.
    
    LayoutTests:
    
    * fast/css-grid-layout/display-grid-set-get-expected.txt: Added.
    * fast/css-grid-layout/display-grid-set-get.html: Added.
    * fast/css-grid-layout/resources/display-grid-set-get.js: Added.
    Test that setting the display to -webkit-grid (from JS or CSS) works
    and we get the right value back.
    
    * platform/chromium/test_expectations.txt:
    * platform/efl/Skipped:
    * platform/gtk/Skipped:
    * platform/mac/Skipped:
    * platform/qt/Skipped:
    * platform/win/Skipped:
    * platform/wincairo/Skipped:
    SKIP the css-grid-layout tests on all platforms for now.
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@100338 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    63c7d1af