-
yosin@chromium.org authored
https://bugs.webkit.org/show_bug.cgi?id=92339 Reviewed by Kent Tamura. Source/WebCore: To detect compilation errors and test failure earlier, I would like build and run tests for input type datetime, datetime-local, month, time and week with runtime feature flags to avoid behavior changes other than test shell. This patch adds runtime features for input types, datetime, datetime-local, month, time and week and integrates them into InputType::createInputTypeFactoryMap to follow runtime feature flags. At this time, these runtime features are enabled by default for all ports define ENABLE_INPUT_TYPE_XXX except for Chromium port other than Android. I'll remove these #if after I update Chromium browser for disabling them for non-Android. No new tests. Enabling disabled tests (fast/forms/datetime, fast/forms/dattimelocal, fast/forms/month, fast/forms/time, fast/forms/week) * bindings/generic/RuntimeEnabledFeatures.cpp: Added initializations of variables for runtime features of input types. * bindings/generic/RuntimeEnabledFeatures.h: (WebCore::RuntimeEnabledFeatures::inputTypeDateTimeEnabled): Added. (WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeEnabled): Added. (WebCore::RuntimeEnabledFeatures::inputTypeDateTimeLocalEnabled): Added. (WebCore::RuntimeEnabledFeatures::setInputTypeDateTimeLocalEnabled): Added. (WebCore::RuntimeEnabledFeatures::inputTypeMonthEnabled): Added. (WebCore::RuntimeEnabledFeatures::setInputTypeMonthEnabled): Added. (WebCore::RuntimeEnabledFeatures::inputTypeTimeEnabled): Added. (WebCore::RuntimeEnabledFeatures::setInputTypeTimeEnabled): Added. (WebCore::RuntimeEnabledFeatures::inputTypeWeekEnabled): Added. (WebCore::RuntimeEnabledFeatures::setInputTypeWeekEnabled): Added. * html/InputType.cpp: (WebCore::createInputTypeFactoryMap): Register input types datetime, datetime-local, month, time and week if corresponding runtime feature flag is enabled. * html/InputType.h: Changed indentation to force building *InputType.cpp for making Chromium-win bots to be happy. Source/WebKit/chromium: To detect compilation errors and test failure earlier, I would like build and run tests for input type datetime, datetime-local, month, time and week with runtime feature flags to avoid behavior changes on chromium browser. This patch adds query and change functions for runtime features of input type datetime, datetime-local, month, time and week to WebRuntimeFeatures class for exposing DRT and chromium browser expermental flags. * features.gypi: Turn on ENABLE_INPUT_TYPE_DATETIME, ENABLE_INPUT_TYPE_DATETIMELOCAL, ENABLE_INPUT_TYPE_MONTH, ENABLE_INPUT_TYPE_TIME, and ENABLE_INPUT_TYPE_WEEK for all OS. * public/WebRuntimeFeatures.h: (WebRuntimeFeatures): * src/WebRuntimeFeatures.cpp: (WebKit::WebRuntimeFeatures::enableInputTypeDateTime): Added. (WebKit::WebRuntimeFeatures::isInputTypeDateTimeEnabled): Added. (WebKit::WebRuntimeFeatures::enableInputTypeDateTimeLocal): Added. (WebKit::WebRuntimeFeatures::isInputTypeDateTimeLocalEnabled): Added. (WebKit::WebRuntimeFeatures::enableInputTypeMonth): Added. (WebKit::WebRuntimeFeatures::isInputTypeMonthEnabled): Added. (WebKit::WebRuntimeFeatures::enableInputTypeTime): Added. (WebKit::WebRuntimeFeatures::isInputTypeTimeEnabled): Added. (WebKit::WebRuntimeFeatures::enableInputTypeWeek): Added. (WebKit::WebRuntimeFeatures::isInputTypeWeekEnabled): Added. Tools: This patch enables runtime features for input type datetime, datetime-local, month, time and week for Chromium DRT. * DumpRenderTree/chromium/TestShell.cpp: (TestShell::TestShell): Call enableInputType{DateTime,DateTimeLocal,Month,Time,Week}. LayoutTests: This patch enables tests for input type datetime, datetime-local, month, time and week for Chromium ports. * platform/chromium/TestExpectations: Removed disabled directives for input type datetime, datetime-local, month, time and week. * platform/chromium/fast/forms/datalist/input-list-expected.txt: Updated expecations for input type datetime, datetime-local, month, time and week to null for IDL list attribute. So far, these expectations specified HTMLDataListElement for input type "text" as unsupported input types. git-svn-id: http://svn.webkit.org/repository/webkit/trunk@123826 268f45cc-cd09-0410-ab3c-d52691b4dbfc
6381e934