• mhahnenberg@apple.com's avatar
    Unzip initialization lists and constructors in JSCell hierarchy (6/7) · 5e10972f
    mhahnenberg@apple.com authored
    https://bugs.webkit.org/show_bug.cgi?id=67692
    
    Reviewed by Geoffrey Garen.
    
    Source/JavaScriptCore:
    
    Completed the sixth level of the refactoring to add finishCreation()
    methods to all classes within the JSCell hierarchy with non-trivial
    constructor bodies.
    
    This primarily consists of pushing the calls to finishCreation() down
    into the constructors of the subclasses of the fifth level of the hierarchy
    as well as pulling the finishCreation() calls out into the class's corresponding
    create() method if it has one.  Doing both simultaneously allows us to
    maintain the invariant that the finishCreation() method chain is called exactly
    once during the creation of an object, since calling it any other number of
    times (0, 2, or more) will cause an assertion failure.
    
    * API/JSCallbackFunction.cpp:
    (JSC::JSCallbackFunction::JSCallbackFunction):
    * API/JSCallbackFunction.h:
    (JSC::JSCallbackFunction::create):
    * jsc.cpp:
    (GlobalObject::create):
    (GlobalObject::GlobalObject):
    * runtime/ArrayConstructor.cpp:
    (JSC::ArrayConstructor::ArrayConstructor):
    * runtime/ArrayConstructor.h:
    (JSC::ArrayConstructor::create):
    * runtime/BooleanConstructor.cpp:
    (JSC::BooleanConstructor::BooleanConstructor):
    * runtime/BooleanConstructor.h:
    (JSC::BooleanConstructor::create):
    * runtime/BooleanPrototype.cpp:
    (JSC::BooleanPrototype::BooleanPrototype):
    * runtime/BooleanPrototype.h:
    (JSC::BooleanPrototype::create):
    * runtime/DateConstructor.cpp:
    (JSC::DateConstructor::DateConstructor):
    * runtime/DateConstructor.h:
    (JSC::DateConstructor::create):
    * runtime/DatePrototype.cpp:
    (JSC::DatePrototype::DatePrototype):
    * runtime/DatePrototype.h:
    (JSC::DatePrototype::create):
    * runtime/Error.cpp:
    (JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
    (JSC::StrictModeTypeErrorFunction::create):
    * runtime/ErrorConstructor.cpp:
    (JSC::ErrorConstructor::ErrorConstructor):
    * runtime/ErrorConstructor.h:
    (JSC::ErrorConstructor::create):
    * runtime/FunctionConstructor.cpp:
    (JSC::FunctionConstructor::FunctionConstructor):
    * runtime/FunctionConstructor.h:
    (JSC::FunctionConstructor::create):
    * runtime/FunctionPrototype.cpp:
    (JSC::FunctionPrototype::FunctionPrototype):
    * runtime/FunctionPrototype.h:
    (JSC::FunctionPrototype::create):
    * runtime/NativeErrorConstructor.cpp:
    (JSC::NativeErrorConstructor::NativeErrorConstructor):
    * runtime/NativeErrorConstructor.h:
    (JSC::NativeErrorConstructor::create):
    * runtime/NativeErrorPrototype.cpp:
    (JSC::NativeErrorPrototype::NativeErrorPrototype):
    (JSC::NativeErrorPrototype::finishCreation):
    * runtime/NativeErrorPrototype.h:
    (JSC::NativeErrorPrototype::create):
    * runtime/NumberConstructor.cpp:
    (JSC::NumberConstructor::NumberConstructor):
    * runtime/NumberConstructor.h:
    (JSC::NumberConstructor::create):
    * runtime/NumberPrototype.cpp:
    (JSC::NumberPrototype::NumberPrototype):
    * runtime/NumberPrototype.h:
    (JSC::NumberPrototype::create):
    * runtime/ObjectConstructor.cpp:
    (JSC::ObjectConstructor::ObjectConstructor):
    * runtime/ObjectConstructor.h:
    (JSC::ObjectConstructor::create):
    * runtime/RegExpConstructor.cpp:
    (JSC::RegExpConstructor::RegExpConstructor):
    * runtime/RegExpConstructor.h:
    (JSC::RegExpConstructor::create):
    * runtime/RegExpPrototype.cpp:
    (JSC::RegExpPrototype::RegExpPrototype):
    * runtime/RegExpPrototype.h:
    (JSC::RegExpPrototype::create):
    * runtime/StringConstructor.cpp:
    (JSC::StringConstructor::StringConstructor):
    * runtime/StringConstructor.h:
    (JSC::StringConstructor::create):
    * runtime/StringObjectThatMasqueradesAsUndefined.h:
    (JSC::StringObjectThatMasqueradesAsUndefined::create):
    (JSC::StringObjectThatMasqueradesAsUndefined::StringObjectThatMasqueradesAsUndefined):
    * runtime/StringPrototype.cpp:
    (JSC::StringPrototype::StringPrototype):
    * runtime/StringPrototype.h:
    (JSC::StringPrototype::create):
    
    Source/JavaScriptGlue:
    
    Completed the sixth level of the refactoring to add finishCreation()
    methods to all classes within the JSCell hierarchy with non-trivial
    constructor bodies.
    
    This primarily consists of pushing the calls to finishCreation() down
    into the constructors of the subclasses of the fifth level of the hierarchy
    as well as pulling the finishCreation() calls out into the class's corresponding
    create() method if it has one.  Doing both simultaneously allows us to
    maintain the invariant that the finishCreation() method chain is called exactly
    once during the creation of an object, since calling it any other number of
    times (0, 2, or more) will cause an assertion failure.
    
    * JSRun.cpp:
    (JSGlueGlobalObject::JSGlueGlobalObject):
    * JSRun.h:
    (JSGlueGlobalObject::create):
    
    Source/WebCore:
    
    No new tests.
    
    Completed the sixth level of the refactoring to add finishCreation()
    methods to all classes within the JSCell hierarchy with non-trivial
    constructor bodies.
    
    This primarily consists of pushing the calls to finishCreation() down
    into the constructors of the subclasses of the fifth level of the hierarchy
    as well as pulling the finishCreation() calls out into the class's corresponding
    create() method if it has one.  Doing both simultaneously allows us to
    maintain the invariant that the finishCreation() method chain is called exactly
    once during the creation of an object, since calling it any other number of
    times (0, 2, or more) will cause an assertion failure.
    
    * WebCore.exp.in:
    * bindings/js/JSDOMBinding.h:
    (WebCore::DOMConstructorObject::DOMConstructorObject):
    (WebCore::DOMConstructorWithDocument::DOMConstructorWithDocument):
    (WebCore::DOMConstructorWithDocument::finishCreation):
    * bindings/js/JSDOMGlobalObject.cpp:
    (WebCore::JSDOMGlobalObject::JSDOMGlobalObject):
    * bindings/js/JSDOMGlobalObject.h:
    * bindings/js/JSDOMWindowBase.cpp:
    (WebCore::JSDOMWindowBase::JSDOMWindowBase):
    (WebCore::JSDOMWindowBase::finishCreation):
    * bindings/js/JSDOMWindowBase.h:
    * bindings/js/JSWorkerContextBase.cpp:
    (WebCore::JSWorkerContextBase::JSWorkerContextBase):
    (WebCore::JSWorkerContextBase::finishCreation):
    * bindings/js/JSWorkerContextBase.h:
    * bindings/scripts/CodeGeneratorJS.pm:
    
    Added a finishCreation declaration and Moved the finishCreation call into the
    create method for all classes except for subclasses of JSWorkerContextBase and
    JSDOMWindowBase because those classes are on the next level, and it's easier
    to do all of these classes in one fell swoop rather than level by level.
    (GenerateHeader):
    Added the implementation of the finishCreation method for the classes described above.
    (GenerateImplementation):
    Also added the finishCreation calls to the autogenerated DOM constructor classes.
    (GenerateConstructorDeclaration):
    (GenerateConstructorDefinition):
    
    * bindings/scripts/test/JS/JSTestInterface.cpp:
    (WebCore::JSTestInterfaceConstructor::create):
    (WebCore::JSTestInterfaceConstructor::JSTestInterfaceConstructor):
    (WebCore::JSTestInterfaceConstructor::finishCreation):
    (WebCore::JSTestInterface::JSTestInterface):
    (WebCore::JSTestInterface::finishCreation):
    * bindings/scripts/test/JS/JSTestInterface.h:
    (WebCore::JSTestInterface::create):
    (WebCore::JSTestInterfacePrototype::create):
    (WebCore::JSTestInterfacePrototype::JSTestInterfacePrototype):
    * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
    (WebCore::JSTestMediaQueryListListenerConstructor::create):
    (WebCore::JSTestMediaQueryListListenerConstructor::JSTestMediaQueryListListenerConstructor):
    (WebCore::JSTestMediaQueryListListenerConstructor::finishCreation):
    (WebCore::JSTestMediaQueryListListener::JSTestMediaQueryListListener):
    (WebCore::JSTestMediaQueryListListener::finishCreation):
    * bindings/scripts/test/JS/JSTestMediaQueryListListener.h:
    (WebCore::JSTestMediaQueryListListener::create):
    (WebCore::JSTestMediaQueryListListenerPrototype::create):
    (WebCore::JSTestMediaQueryListListenerPrototype::JSTestMediaQueryListListenerPrototype):
    * bindings/scripts/test/JS/JSTestObj.cpp:
    (WebCore::JSTestObjConstructor::create):
    (WebCore::JSTestObjConstructor::JSTestObjConstructor):
    (WebCore::JSTestObjConstructor::finishCreation):
    (WebCore::JSTestObj::JSTestObj):
    (WebCore::JSTestObj::finishCreation):
    * bindings/scripts/test/JS/JSTestObj.h:
    (WebCore::JSTestObj::create):
    (WebCore::JSTestObjPrototype::create):
    (WebCore::JSTestObjPrototype::JSTestObjPrototype):
    * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
    (WebCore::JSTestSerializedScriptValueInterfaceConstructor::create):
    (WebCore::JSTestSerializedScriptValueInterfaceConstructor::JSTestSerializedScriptValueInterfaceConstructor):
    (WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):
    (WebCore::JSTestSerializedScriptValueInterface::JSTestSerializedScriptValueInterface):
    (WebCore::JSTestSerializedScriptValueInterface::finishCreation):
    * bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
    (WebCore::JSTestSerializedScriptValueInterface::create):
    (WebCore::JSTestSerializedScriptValueInterfacePrototype::create):
    (WebCore::JSTestSerializedScriptValueInterfacePrototype::JSTestSerializedScriptValueInterfacePrototype):
    * bridge/c/CRuntimeObject.cpp:
    (JSC::Bindings::CRuntimeObject::CRuntimeObject):
    * bridge/c/CRuntimeObject.h:
    (JSC::Bindings::CRuntimeObject::create):
    * bridge/c/c_instance.cpp:
    (JSC::Bindings::CRuntimeMethod::CRuntimeMethod):
    (JSC::Bindings::CRuntimeMethod::finishCreation):
    * bridge/jni/jsc/JavaInstanceJSC.cpp:
    (JavaRuntimeMethod::JavaRuntimeMethod):
    (JavaRuntimeMethod::finishCreation):
    * bridge/jni/jsc/JavaRuntimeObject.cpp:
    (JSC::Bindings::JavaRuntimeObject::JavaRuntimeObject):
    * bridge/jni/jsc/JavaRuntimeObject.h:
    (JSC::Bindings::JavaRuntimeObject::create):
    * bridge/objc/ObjCRuntimeObject.h:
    (JSC::Bindings::ObjCRuntimeObject::create):
    * bridge/objc/ObjCRuntimeObject.mm:
    (JSC::Bindings::ObjCRuntimeObject::ObjCRuntimeObject):
    * bridge/objc/objc_instance.mm:
    (ObjCRuntimeMethod::ObjCRuntimeMethod):
    (ObjCRuntimeMethod::finishCreation):
    * bridge/qt/qt_instance.cpp:
    (JSC::Bindings::QtRuntimeObject::create):
    (JSC::Bindings::QtRuntimeObject::QtRuntimeObject):
    * bridge/qt/qt_pixmapruntime.cpp:
    (JSC::Bindings::QtPixmapRuntimeObject::create):
    (JSC::Bindings::QtPixmapRuntimeObject::QtPixmapRuntimeObject):
    * bridge/qt/qt_runtime.cpp:
    (JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
    (JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
    (JSC::Bindings::QtRuntimeMetaMethod::finishCreation):
    (JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
    (JSC::Bindings::QtRuntimeConnectionMethod::finishCreation):
    * bridge/qt/qt_runtime.h:
    (JSC::Bindings::QtRuntimeMetaMethod::create):
    * bridge/runtime_method.cpp:
    (JSC::RuntimeMethod::RuntimeMethod):
    * bridge/runtime_method.h:
    (JSC::RuntimeMethod::create):
    
    Source/WebKit/mac:
    
    Completed the sixth level of the refactoring to add finishCreation()
    methods to all classes within the JSCell hierarchy with non-trivial
    constructor bodies.
    
    This primarily consists of pushing the calls to finishCreation() down
    into the constructors of the subclasses of the fifth level of the hierarchy
    as well as pulling the finishCreation() calls out into the class's corresponding
    create() method if it has one.  Doing both simultaneously allows us to
    maintain the invariant that the finishCreation() method chain is called exactly
    once during the creation of an object, since calling it any other number of
    times (0, 2, or more) will cause an assertion failure.
    
    * Plugins/Hosted/ProxyInstance.mm:
    (WebKit::ProxyRuntimeMethod::ProxyRuntimeMethod):
    (WebKit::ProxyRuntimeMethod::finishCreation):
    
    Source/WebKit2:
    
    Completed the sixth level of the refactoring to add finishCreation()
    methods to all classes within the JSCell hierarchy with non-trivial
    constructor bodies.
    
    This primarily consists of pushing the calls to finishCreation() down
    into the constructors of the subclasses of the fifth level of the hierarchy
    as well as pulling the finishCreation() calls out into the class's corresponding
    create() method if it has one.  Doing both simultaneously allows us to
    maintain the invariant that the finishCreation() method chain is called exactly
    once during the creation of an object, since calling it any other number of
    times (0, 2, or more) will cause an assertion failure.
    
    * WebProcess/Plugins/Netscape/JSNPMethod.cpp:
    (WebKit::JSNPMethod::JSNPMethod):
    * WebProcess/Plugins/Netscape/JSNPMethod.h:
    (WebKit::JSNPMethod::create):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@95108 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    5e10972f
StringConstructor.cpp 4.31 KB