Skip to content
  • adachan@apple.com's avatar
    WebCore: · 5dfb49d2
    adachan@apple.com authored
            Tabs with ctrl, meta, or altgraph modifier key down should not advance focus.
    
            Reviewed by Darin.
    
            Test: fast/forms/tabs-with-modifiers.html
    
            * page/EventHandler.cpp:
            (WebCore::EventHandler::defaultKeyboardEventHandler):
            (WebCore::EventHandler::defaultTabEventHandler): bail if ctrl, meta, or altgraph key is down.  
            Clean up the code a bit.
            * page/EventHandler.h:
            * page/FocusController.cpp: Remove the advanceFocus() that takes in a KeyboardEvent.  It was
            only called in EventHandler::defaultTabEventHandler() but we have cleaned up the code there and
            no longer needs it.
            * page/FocusController.h:
            
    LayoutTests:
            Tests tabbing with different combinations of modifiers keys, where some
            should advance focus and some should not.
    
            Reviewed by Darin.
    
            * fast/forms/tabs-with-modifiers-expected.txt: Added.
            * fast/forms/tabs-with-modifiers.html: Copied from fast/forms/focus2.html.
            
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@29348 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    5dfb49d2