Skip to content
  • commit-queue@webkit.org's avatar
    [chromium] Clean up WebWidget / WebLayerTreeView interactions · 5b594372
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=109125
    
    Patch by James Robinson <jamesr@chromium.org> on 2013-03-05
    Reviewed by Adrienne Walker.
    
    Source/Platform:
    
    This deprecates most of the calls on WebLayerTreeViewClient since these interactions are handled
    entirely on the embedder side of the interface now.
    
    * chromium/public/WebLayerTreeView.h:
    (WebLayerTreeView):
    * chromium/public/WebLayerTreeViewClient.h:
    (WebLayerTreeViewClient):
    (WebKit::WebLayerTreeViewClient::willBeginFrame):
    (WebKit::WebLayerTreeViewClient::didBeginFrame):
    (WebKit::WebLayerTreeViewClient::applyScrollAndScale):
    (WebKit::WebLayerTreeViewClient::layout):
    (WebKit::WebLayerTreeViewClient::didRecreateOutputSurface):
    (WebKit::WebLayerTreeViewClient::createInputHandler):
    (WebKit::WebLayerTreeViewClient::createOutputSurface):
    (WebKit::WebLayerTreeViewClient::willCommit):
    (WebKit::WebLayerTreeViewClient::didCommit):
    (WebKit::WebLayerTreeViewClient::didCommitAndDrawFrame):
    (WebKit::WebLayerTreeViewClient::didCompleteSwapBuffers):
    
    Source/WebKit/chromium:
    
    This removes most of the compositing control flow logic from WebViewImpl since
    it is now handled in the embedding layer (by the implementation of WebViewClient/WebWidgetClient).
    
    * public/WebViewClient.h:
    * public/WebWidget.h:
    (WebKit):
    (WebKit::WebWidget::animate):
    (WebWidget):
    (WebKit::WebWidget::didExitCompositingMode):
    (WebKit::WebWidget::createInputHandler):
    (WebKit::WebWidget::applyScrollAndScale):
    (WebKit::WebWidget::instrumentBeginFrame):
    (WebKit::WebWidget::instrumentWillBeginFrame):
    (WebKit::WebWidget::instrumentDidCancelFrame):
    (WebKit::WebWidget::instrumentDidBeginFrame):
    (WebKit::WebWidget::instrumentWillComposite):
    * src/WebHelperPluginImpl.cpp:
    * src/WebHelperPluginImpl.h:
    (WebHelperPluginImpl):
    * src/WebPagePopupImpl.cpp:
    * src/WebPagePopupImpl.h:
    (WebPagePopupImpl):
    * src/WebPopupMenuImpl.cpp:
    * src/WebPopupMenuImpl.h:
    * src/WebViewImpl.cpp:
    (WebKit::WebViewImpl::instrumentWillBeginFrame):
    (WebKit::WebViewImpl::instrumentDidBeginFrame):
    (WebKit::WebViewImpl::instrumentDidCancelFrame):
    (WebKit::WebViewImpl::instrumentWillComposite):
    (WebKit):
    (WebKit::WebViewImpl::updateBatteryStatus):
    (WebKit::WebViewImpl::animate):
    (WebKit::WebViewImpl::didExitCompositingMode):
    * src/WebViewImpl.h:
    * tests/WebLayerTreeViewTestCommon.h:
    (MockWebLayerTreeViewClient):
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@144784 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    5b594372