Skip to content
  • kbr@google.com's avatar
    2011-01-18 Kenneth Russell <kbr@google.com> · 592c4269
    kbr@google.com authored
            Reviewed by David Levin.
    
            Must strip comments from WebGL shaders before enforcing character set
            https://bugs.webkit.org/show_bug.cgi?id=52390
    
            Strip comments from incoming shaders, preserving line numbers,
            before validating that they conform to the ESSL character set.
            Revert changes from http://trac.webkit.org/changeset/75735 which
            allowed invalid characters to be passed to certain APIs.
    
            Tested with WebGL layout tests, conformance test suite and several
            WebGL demos in both Safari and Chromium.
    
            * html/canvas/WebGLRenderingContext.cpp:
            (WebCore::StripComments::StripComments::process):
            (WebCore::WebGLRenderingContext::shaderSource):
    2011-01-18  Kenneth Russell  <kbr@google.com>
    
            Reviewed by David Levin.
    
            Must strip comments from WebGL shaders before enforcing character set
            https://bugs.webkit.org/show_bug.cgi?id=52390
    
            Incorporated non-ASCII GLSL conformance tests from Khronos
            repository. Updated and synchronized invalid-passed-params.html
            with Khronos repository, undoing changes from
            http://trac.webkit.org/changeset/75735 .
    
            * fast/canvas/webgl/glsl-conformance-expected.txt:
            * fast/canvas/webgl/invalid-passed-params-expected.txt:
            * fast/canvas/webgl/invalid-passed-params.html:
            * fast/canvas/webgl/shaders/00_shaders.txt:
            * fast/canvas/webgl/shaders/misc: Added.
            * fast/canvas/webgl/shaders/misc/00_shaders.txt: Added.
            * fast/canvas/webgl/shaders/misc/non-ascii-comments.vert: Added.
            * fast/canvas/webgl/shaders/misc/non-ascii.vert: Added.
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@76063 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    592c4269