Skip to content
  • commit-queue@webkit.org's avatar
    Modifying RTCSessionDescription object construction to match the spec · 53a006ec
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=124212
    
    Patch by Thiago de Barros Lacerda <thiago.lacerda@openbossa.org> on 2013-11-13
    Reviewed by Eric Carlson.
    
    According to the spec the RTCSessionDescriptionInit parameter in RTCSessionDescription constructor is optional,
    which must not be nullable. If the 'type' and/or 'sdp' keys are not present, the string object that stores
    them in the RTCSessionDescription class, must be null in those cases. Also, if an object that is not a
    Dictionary is passed as argument to the constructor, an exception must be raised.
    
    Source/WebCore:
    
    Existing test was updated.
    
    * GNUmakefile.list.am:
    * Modules/mediastream/RTCSessionDescription.cpp:
    (WebCore::RTCSessionDescription::create):
    * Modules/mediastream/RTCSessionDescription.idl:
    * UseJSC.cmake:
    * WebCore.vcxproj/WebCore.vcxproj:
    * WebCore.vcxproj/WebCore.vcxproj.filters:
    * WebCore.xcodeproj/project.pbxproj:
    * bindings/js/JSRTCSessionDescriptionCustom.cpp: Added.
    (WebCore::JSRTCSessionDescriptionConstructor::constructJSRTCSessionDescription):
    
    LayoutTests:
    
    * fast/mediastream/RTCSessionDescription-expected.txt:
    * fast/mediastream/RTCSessionDescription.html:
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@159230 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    53a006ec