Skip to content
  • rniwa@webkit.org's avatar
    Replace isolate || bidi-override by isolate-override · 4d4bd334
    rniwa@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=89746
    
    Reviewed by Levi Weintraub.
    
    Source/WebCore: 
    
    The combination of bidi-isolate and isolate was replaced by a single isolate-override in
    http://lists.w3.org/Archives/Public/www-style/2012May/0541.html. The spec. has been updated accordingly:
    http://dev.w3.org/csswg/css3-writing-modes/#unicode-bidi
    
    To follow the specification change, added -webkit-isolate-override and removed the support for
    isolate || bidi-override, simplifying the CSS parser and serializer.
    
    Test: fast/text/bidi-override-isolate.html
    
    * css/CSSComputedStyleDeclaration.cpp:
    (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Removed. We can just new a CSSPrimitiveValue
    constructor now.
    * css/CSSParser.cpp:
    (WebCore::CSSParser::parseValue):
    * css/CSSPrimitiveValueMappings.h:
    (WebCore::CSSPrimitiveValue::CSSPrimitiveValue): Added now that unicode-bidi always creates a signle
    primitive value instead of a primitive value of css value list.
    (WebCore::CSSPrimitiveValue::operator EUnicodeBidi):
    * css/CSSValueKeywords.in: Added -webkit-isolate-override
    * css/StyleBuilder.cpp:
    (WebCore): Removed ApplyPropertyUnicodeBidi since we can use ApplyPropertyDefault now.
    (WebCore::StyleBuilder::StyleBuilder): Use ApplyPropertyDefault.
    * platform/text/UnicodeBidi.h: Renamed OverrideIsolate to IsolateOverride to match the spec.
    (WebCore::isIsolated):
    (WebCore::isOverride):
    * rendering/RenderBlockLineLayout.cpp:
    (WebCore::constructBidiRuns):
    
    LayoutTests: 
    
    Rebaseline test expectations. These tests test the new behavior and new property value -webkit-isolate-override.
    
    * fast/css/unicode-bidi-computed-value-expected.txt:
    * fast/css/unicode-bidi-computed-value.html:
    * fast/text/bidi-override-isolate.html:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@126072 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    4d4bd334