Skip to content
  • morrita@google.com's avatar
    ElementShadow should minimize the usage of "ShadowRoot" name · 49d99d93
    morrita@google.com authored
    https://bugs.webkit.org/show_bug.cgi?id=85970
    
    Reviewed by Dimitri Glazkov.
    
    .:
    
    Removed symbols which no longer exists
    
    * Source/autotools/symbols.filter:
    
    Source/WebCore:
    
    This change cleans two out dated assumptions which brought in at
    early stage of Shadow DOM implementation.
    
    - Removed Element::hasShadowRoot(): shadow existence can be checked by Element::shadow().
    - Made ElementShadow::removeAllShadowRoots() private: we no longer allow ShadowRoot removal.
      It can only happens at the ElementShadow destruction.
    
    Most of changes in element implementations are basically simple
    replacement from hasShadowRoot() to shadow().
    
    No new tests. Covered by existing tests.
    
    * WebCore.exp.in:
    * dom/ContainerNodeAlgorithms.h:
    (WebCore::ChildFrameDisconnector::collectDescendant):
    * dom/ComposedShadowTreeWalker.cpp:
    (WebCore::ComposedShadowTreeWalker::traverseChild):
    * dom/Document.cpp:
    (WebCore::Document::buildAccessKeyMap):
    * dom/Element.cpp:
    (WebCore::Element::recalcStyle):
    (WebCore::Element::ensureShadowRoot):
    (WebCore::Element::childrenChanged):
    * dom/Element.h:
    (Element):
    (WebCore::isShadowHost):
    (WebCore):
    * dom/ElementShadow.cpp:
    (WebCore::ElementShadow::~ElementShadow):
    (WebCore::ElementShadow::removeAllShadowRoots):
    * dom/ElementShadow.h:
    (ElementShadow):
    (WebCore::ElementShadow::host):
    * dom/EventDispatcher.cpp:
    * dom/Node.cpp:
    (WebCore::oldestShadowRootFor):
    * dom/NodeRenderingContext.cpp:
    (WebCore::NodeRenderingContext::NodeRenderingContext):
    * dom/ShadowRoot.cpp:
    (WebCore::ShadowRoot::create):
    * html/ColorInputType.cpp:
    (WebCore::ColorInputType::createShadowSubtree):
    * html/FileInputType.cpp:
    (WebCore::FileInputType::createShadowSubtree):
    (WebCore::FileInputType::multipleAttributeChanged):
    * html/HTMLDetailsElement.cpp:
    (WebCore::HTMLDetailsElement::createShadowSubtree):
    * html/HTMLInputElement.cpp:
    (WebCore::HTMLInputElement::createShadowSubtree):
    * html/HTMLKeygenElement.cpp:
    (WebCore::HTMLKeygenElement::HTMLKeygenElement):
    (WebCore::HTMLKeygenElement::shadowSelect):
    * html/HTMLMediaElement.cpp:
    (WebCore::HTMLMediaElement::hasMediaControls):
    * html/HTMLMeterElement.cpp:
    (WebCore::HTMLMeterElement::createShadowSubtree):
    * html/HTMLProgressElement.cpp:
    (WebCore::HTMLProgressElement::createShadowSubtree):
    * html/HTMLSummaryElement.cpp:
    (WebCore::HTMLSummaryElement::createShadowSubtree):
    * html/HTMLTextAreaElement.cpp:
    (WebCore::HTMLTextAreaElement::createShadowSubtree):
    * html/InputType.cpp:
    (WebCore::InputType::destroyShadowSubtree):
    * html/RangeInputType.cpp:
    (WebCore::RangeInputType::handleMouseDownEvent):
    (WebCore::RangeInputType::createShadowSubtree):
    * html/TextFieldInputType.cpp:
    (WebCore::TextFieldInputType::createShadowSubtree):
    * html/shadow/SliderThumbElement.cpp:
    (WebCore::trackLimiterElementOf):
    * inspector/InspectorDOMAgent.cpp:
    (WebCore::InspectorDOMAgent::unbind):
    (WebCore::InspectorDOMAgent::buildObjectForNode):
    * page/FocusController.cpp:
    (WebCore):
    * rendering/RenderFileUploadControl.cpp:
    (WebCore::RenderFileUploadControl::uploadButton):
    * svg/SVGTRefElement.cpp:
    (WebCore::SVGTRefElement::updateReferencedText):
    (WebCore::SVGTRefElement::detachTarget):
    * testing/Internals.cpp:
    (WebCore::Internals::ensureShadowRoot):
    (WebCore::Internals::youngestShadowRoot):
    (WebCore::Internals::oldestShadowRoot):
    * testing/Internals.h:
    (Internals):
    * testing/Internals.idl:
    
    Source/WebKit2:
    
    Removed symbols which no longer exists
    
    * win/WebKit2.def:
    * win/WebKit2CFLite.def:
    
    LayoutTests:
    
    Removed tests cases which exercise shadow root removals.
    Such functionality was only available from Internals object
    and it made little sense to test it.
    
    * fast/dom/shadow/content-element-move-expected.txt:
    * fast/dom/shadow/content-element-move.html:
    * fast/dom/shadow/dynamically-created-shadow-root-expected.html:
    * fast/dom/shadow/dynamically-created-shadow-root.html:
    * fast/dom/shadow/layout-tests-can-access-shadow-expected.txt:
    * fast/dom/shadow/layout-tests-can-access-shadow.html:
    * fast/dom/shadow/multiple-shadowroot-expected.txt:
    * fast/dom/shadow/multiple-shadowroot.html:
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@116730 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    49d99d93