Skip to content
  • commit-queue@webkit.org's avatar
    .: Expose an export for the iconUrl list so Internals can use it · 466dbd4b
    commit-queue@webkit.org authored
    https://bugs.webkit.org/show_bug.cgi?id=88665
    
    Patch by Pete Williamson <petewil@google.com> on 2012-07-16
    Reviewed by Kent Tamura.
    
    * Source/autotools/symbols.filter: export iconURLs
    
    Source/WebCore: Changed the behavior of iconURLs to always recalculate the list.
    https://bugs.webkit.org/show_bug.cgi?id=88665
    
    Patch by Pete Williamson <petewil@google.com> on 2012-07-16
    Reviewed by Kent Tamura.
    
    As it turns out, it can contain stale URLs in the case that some script
    manipulates the DOM, which breaks scripts trying to reset the favicon
    URL. Also added a method in Internals to allow tests to get the list of
    icon
    
    Tests: fast/dom/icon-url-change.html
           fast/dom/icon-url-list.html
    
    * WebCore.exp.in: export Document::iconURLs on the mac for the Internals class
    * dom/Document.cpp:
    (WebCore::Document::iconURLs): Changed the method to recalculate the iconURL list every time
    (WebCore::Document::addIconURL): we no longer need to add to the internal list since we recalculate it
    (WebCore::Document::setUseSecureKeyboardEntryWhenActive): removed extra whitespace
    * dom/Document.h:
    (Document): removed the addIconURL method which is no longer used
    * html/HTMLLinkElement.cpp:
    (WebCore::HTMLLinkElement::iconType): exposed the icon type with an accessor
    (WebCore):
    (WebCore::HTMLLinkElement::iconSizes): exposed the icon sizes with an accessor
    * html/HTMLLinkElement.h:
    (HTMLLinkElement): declared the icon type and size accessors
    * testing/Internals.cpp:
    (WebCore::Internals::iconURLs): made a method to be used by unit tests for inspecting the icon URL list
    (WebCore):
    * testing/Internals.h:
    (Internals): declared the method for unit testing the icon URL list
    * testing/Internals.idl: exported the Document::iconURLs function
    
    Source/WebKit2: Export the iconURL list to make it available to the Internals class for testing
    https://bugs.webkit.org/show_bug.cgi?id=88665
    
    Patch by Pete Williamson <petewil@google.com> on 2012-07-16
    Reviewed by Kent Tamura.
    
    * win/WebKit2.def: export the DocumentL::iconURLs function
    
    LayoutTests: Add some new unit tests to test the favicon changing dynamically
    https://bugs.webkit.org/show_bug.cgi?id=88665
    
    Patch by Pete Williamson <petewil@google.com> on 2012-07-16
    Reviewed by Kent Tamura.
    
    * fast/dom/icon-url-change-expected.txt: Added.
    * fast/dom/icon-url-change.html: Added a new test for changing the favicon dynamically
    * fast/dom/icon-url-list-expected.txt: Added.
    * fast/dom/icon-url-list.html: Added a new test for multiple favicons in the HTML header
    * fast/dom/icon-url-property-expected.txt: update unit test expectations
    * fast/dom/icon-url-property.html: update and enable existing favicon test
    * platform/chromium/TestExpectations: reenable the url-property test
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@122806 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    466dbd4b