Skip to content
  • tommyw@google.com's avatar
    MediaStream API: RTCPeerConnection should send down its handler via the... · 46689138
    tommyw@google.com authored
    MediaStream API: RTCPeerConnection should send down its handler via the FrameLoaderClient directly after creation.
    https://bugs.webkit.org/show_bug.cgi?id=98149
    
    Reviewed by Adam Barth.
    
    Source/WebCore:
    
    The chromium implementation needs to know which Frame created a PeerConnection so
    that the right housekeeping can take place correctly.
    
    Not testable in DRT, but have verified the change manually and with our pyautotests.
    
    * Modules/mediastream/RTCPeerConnection.cpp:
    (WebCore::RTCPeerConnection::RTCPeerConnection):
    * loader/FrameLoaderClient.h:
    (WebCore):
    (FrameLoaderClient):
    (WebCore::FrameLoaderClient::dispatchWillStartUsingPeerConnectionHandler):
    * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
    (WebCore::RTCPeerConnectionHandlerChromium::toWebRTCPeerConnectionHandler):
    (WebCore):
    (WebCore::RTCPeerConnectionHandlerChromium::RTCPeerConnectionHandlerChromium):
    (WebCore::RTCPeerConnectionHandlerChromium::initialize):
    * platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
    (RTCPeerConnectionHandlerChromium):
    
    Source/WebKit/chromium:
    
    Adding willStartUsingPeerConnectionHandler to the WebFrameClient.
    
    * public/WebFrameClient.h:
    (WebKit):
    (WebFrameClient):
    (WebKit::WebFrameClient::willStartUsingPeerConnectionHandler):
    * src/FrameLoaderClientImpl.cpp:
    (WebKit):
    (WebKit::FrameLoaderClientImpl::dispatchWillStartUsingPeerConnectionHandler):
    * src/FrameLoaderClientImpl.h:
    (FrameLoaderClientImpl):
    
    
    git-svn-id: http://svn.webkit.org/repository/webkit/trunk@130270 268f45cc-cd09-0410-ab3c-d52691b4dbfc
    46689138